watching stops without any notification

[grosser]

Already saw multiple times that the watcher just stops ... without crashing / notifying ...
Idk how to reproduce that, but it happens regularly ... and it does not happen for kube-proxy so either there is a bug in this library or kube-proxy go-lang code has some smart disconnect handling

atm using below and calling .restart every x minutes

class KubernetesWatcher
  def initialize(kuber_client, namespace)
    @kuber_client = kuber_client
    @namespace = namespace
  end

  def watch(&block)
    loop do
      @watcher = @kuber_client.watch_endpoints(namespace: @namespace)
      @watcher.each(&block)
    end
  end

  def restart
    @watcher.finish
  end
end

idk how to fix/debug this further but wanted to raise awareness.

[simon3z]

cc @cben @agrare @moolitayer

[cben]

@grosser when you say "just stops" do you mean .each { block... } returns at some point?
or keeps running but never calls the block?

Which kubernetes version are you connecting to? And which ruby you're running?

don't know if related but I run oc get pod --watch yesterday and noticed it just exited after some time.

[grosser]

idk if the block stops or it just idles ... I'll try to find out ... if that's the problem then it's easy to fix :D

…

On Thu, Nov 2, 2017 at 3:35 PM, Beni Cherniavsky-Paskin < ***@***.***> wrote: @grosser <https://github.com/grosser> when you say "just stops" do you mean .each { block... } returns at some point? or keeps running but never calls the block? Which kubernetes version are you connecting to? And which ruby you're running? don't know if related but I run oc get pod --watch yesterday and noticed it just exited after some time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#273 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ4AOcWzGSn82WkeHSt3-l4JrUOXVks5sykOngaJpZM4QQWhG> .

[grosser]

confirmed that the block just stops ... so having a reconnect by default or optional would be nice ... atm I'm just doing loop do ... watch ... end

[simon3z]

Actually I am not sure we want to add this in the lib. How would you know that there was a disconnection? (Maybe some message was lost, etc.). I would keep this as is.

[grosser]

then we should call that out in the readme ... "watcher will stop when it is disconnected, run it in a loop to make sure it stays running" or so

…

On Fri, Nov 3, 2017 at 5:17 AM, Federico Simoncelli < ***@***.***> wrote: Actually I am not sure we want to add this in the lib. How would you know that there was a disconnection? (Maybe some message was lost, etc.). I would keep this as is. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#273 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZwUVxUKbjxfeiSU_FDqn_PFVDLOyks5sywRSgaJpZM4QQWhG> .

[simon3z]

then we should call that out in the readme ... "watcher will stop when it
is disconnected, run it in a loop to make sure it stays running" or so

Definitely 👍