Externalized MagicPaintjob 2.0 strings.

Author: wispborne

data/strings/strings.json

@@ -304,7 +304,14 @@
     "ml_mp_permanentTooltipRefit":"This paintjob is permanent and cannot be changed.",
     "ml_mp_shiny":"This is a rare paintjob.",
     "ml_mp_appliedRefit":"Applied: %s",
+    "ml_mp_refit_paintjob": "Paintjob",
+    "ml_mp_refit_goBack": "Go Back",
+    "ml_mp_refit_defaultDesc": "The Standard Paintjob",
+    "ml_mp_refit_locked": "LOCKED",
+    # The text on the Vanilla button to add a hullmod to your ship. Used for reflection.
+    "ml_mp_refit_vanillaHullmodAddButtonText": "Add",
 
+    # MagicSubsystem
     "subsystemTitleText": "SUBSYSTEMS",
     "subsystemNameWithKeyText": "%s [%s]",
     "subsystemMoreInfoText": "PRESS %s FOR MORE INFO",

jars/MagicLib.jar

@@ -8,6 +8,6 @@
     {
       "major": "1",
       "minor": "5",
-      "patch": "2"
+      "patch": "3-RC01"
     }
 }

magiclib.version

@@ -4,7 +4,7 @@
   "author": "Modding Community: Dark.Revenant, LazyWizard, Nicke, Originem, Rubi, Schaf-Unschaf, Snrasha, Tartiflette, Wisp, Wyvern...",
   "utility": "false",
   # Using the long version format lets the game correctly compare major/minor/patch versions.
-  "version": { "major": '1', "minor": '5', "patch": '2' },
+  "version": { "major": '1', "minor": '5', "patch": '3-RC01' },
   "description": "A collection of classes to aid modding. Not a mod in itself, but required by other mods.",
   "gameVersion": "0.98a-RC04",
   "dependencies": [

mod_info.json

@@ -2,4 +2,6 @@
   - BetterVariants
   - Tart's mods
 - Make sure `mod_info.json` and all fields in the `.version` file are updated.
+- Make sure all strings are externalized.
+
 - Update wiki.

release_checklist.md

@@ -17,7 +17,11 @@ import org.magiclib.kotlin.*
 import java.awt.Color
 import org.magiclib.paintjobs.MagicPaintjobSelector.createPaintjobSelector
 import org.magiclib.paintjobs.MagicPaintjobSelector.MagicPaintjobSelectorPlugin
+import org.magiclib.util.MagicTxt
 
+/**
+ * @author Starficz
+ */
 internal object MagicPaintjobRefitPanel {
     private const val BACKGROUND_ALPHA = 0.7f
     internal class MagicPaintjobRefitPanelPlugin(private val refitTab: UIPanelAPI) : BaseCustomUIPanelPlugin() {
@@ -135,7 +139,7 @@ internal object MagicPaintjobRefitPanel {
             // add tooltip to locked paintjobs
             if(!selectorPlugin.isUnlocked && !paintjobSpec?.unlockConditions.isNullOrBlank()){
                 scrollerTooltip.addTooltip(selectorPanel, TooltipMakerAPI.TooltipLocation.BELOW, 250f) { tooltip ->
-                    tooltip.addTitle("LOCKED")
+                    tooltip.addTitle(MagicTxt.getString("ml_mp_refit_locked"))
                     tooltip.addPara(paintjobSpec!!.unlockConditions, 0f)
                 }
             }

src/org/magiclib/paintjobs/MagicPaintjobRefitPanel.kt

@@ -9,7 +9,11 @@ import org.magiclib.internalextensions.*
 import java.awt.Color
 import org.magiclib.kotlin.setAlpha
 import org.magiclib.paintjobs.MagicPaintjobRefitPanel.createMagicPaintjobRefitPanel
+import org.magiclib.util.MagicTxt
 
+/**
+ * @author Starficz
+ */
 internal object MagicPaintjobRefitPanelCreator {
     private val PAINTJOB_BUTTON_COLOR = Color(240, 160, 0, 130)
     private val PAINTJOB_BUTTON_TEXT_COLOR = PAINTJOB_BUTTON_COLOR.brighter().setAlpha(255)
@@ -37,12 +41,12 @@ internal object MagicPaintjobRefitPanelCreator {
 
         // addHullmods button should always exist in hullmodsPanel
         val addButton = existingElements.filter { ReflectionUtils.hasMethodOfName("getText", it) }.find {
-            (ReflectionUtils.invoke("getText", it) as String).contains("Add")
+            (ReflectionUtils.invoke("getText", it) as String).contains(MagicTxt.getString("ml_mp_refit_vanillaHullmodAddButtonText"))
         } ?: return
 
         // make a new button
         val newPaintjobButton = hullmodsPanel.addButton(
-            "Paintjob",
+            MagicTxt.getString("ml_mp_refit_paintjob"),
             "PAINTJOB_BUTTON",
             PAINTJOB_BUTTON_TEXT_COLOR,
             PAINTJOB_BUTTON_COLOR,
@@ -72,7 +76,7 @@ internal object MagicPaintjobRefitPanelCreator {
 
             // add back button here to make sure its lined up with existing button
             val goBackButton = paintjobPanel.addButton(
-                "Go Back",
+                MagicTxt.getString("ml_mp_refit_goBack"),
                 null,
                 PAINTJOB_BUTTON_TEXT_COLOR,
                 PAINTJOB_BUTTON_COLOR,

src/org/magiclib/paintjobs/MagicPaintjobRefitPanelCreator.kt

@@ -14,9 +14,13 @@ import org.lwjgl.opengl.GL11
 import org.magiclib.ReflectionUtils
 import org.magiclib.internalextensions.*
 import org.magiclib.kotlin.*
+import org.magiclib.util.MagicTxt
 import java.awt.Color
 import kotlin.math.max
 
+/**
+ * @author Starficz
+ */
 internal object MagicPaintjobSelector {
     internal class MagicPaintjobSelectorPlugin(val paintjobSpec: MagicPaintjobSpec?) : BaseCustomUIPanelPlugin() {
         lateinit var selectorPanel: CustomPanelAPI
@@ -180,8 +184,8 @@ internal object MagicPaintjobSelector {
         with(textElement){
             position.inTL(0f, width+topPad)
             setTitleOrbitronLarge()
-            addTitle(paintjobSpec?.name ?: "Default")
-            addPara(paintjobSpec?.description ?: "The Standard Paintjob", 3f)
+            addTitle(paintjobSpec?.name ?: MagicTxt.getString("ml_mp_default"))
+            addPara(paintjobSpec?.description ?: MagicTxt.getString("ml_mp_refit_defaultDesc"), 3f)
         }
 
         return selectorPanel