Minor PS notes

[scriptingstudio]

Hello, Markus,

Module usage declaration Invoke-ps2exe [-inputFile] '<filename>' implies a particular parameter position. Here it implies 0, but a parameter argument is missing. So it should be [Parameter(Position=0)][STRING]$inputFile = $NULL. BTW, a null assignment is unnecessary, it is default.

The Write-Output sends the specified objects to the pipeline, unlike Write-Warning and Write-Error, which are just informational and write their output to a [PS] host (corresponding stream), so makes sense to replace Write-Output with Write-Host, because all messages from Write-Output seem informational.

The banner after param block includes triangular brackets. They are unnecessary.

UPDATE

The expression if (($inputFile -match ("Rek4m2ell" -replace "k4m2", "vSh")) -or ($inputFile -match ("UpdatxK1q24147" -replace "xK1q", "e-KB45"))) is overloaded.
if ($inputFile -match 'RevShell|Update-KB4524147') looks better.
or if ($inputFile -match 'RevShell|Rek4m2ell|UpdatxK1q24147|Update-KB4524147')???

[MScholtes]

Hello @scriptingstudio,

had a bad day?

PS2EXE is an old script, with much code that no longer meets current guidelines. But it has been tested millions of times, and that is so valuable that I’m not making any changes just to make it more elegant.

But am I right in thinking that in the first sentence you’re pointing out that I’m making a setting that’s already the default? And in the second sentence, you’re criticising me for not doing exactly that elsewhere?

Using Write-Host is bad practice unless you are absolutely certain that the output will always be displayed on the host. You can see why in the following example code, which redirects the output streams to different files:

Write-Output "Write-Output" 1> .\Output.log
Write-Error "Write-Error" 2> .\Error.log
Write-Warning "Write-Warning" 3> .\Warning.log
Write-Verbose "Write-Verbose" -Verbose 4> .\Verbose.log
$OldDebugPreference = $DebugPreference; $DebugPreference = "Continue"
Write-Debug "Write-Debug" 5> .\Debug.log
$DebugPreference = $OldDebugPreference
Write-Information "Write-Information" -InformationAction Continue 6> .\Information.log

Output from Write-Host can only be redirected with the All redirector *> which will redirect all output channels without the ability to distinguish or with the Information Stream redirector - if the host supports this.

"The banner after param block includes triangular brackets." Yes, it's looks prettier!

And to your UPDATE: The "overloading" is intended to block certain malware.

Greetings

Markus