The inventory causes the game to stutter when opening it.

[SaintWish]

It seems to be caused by how many items you have on your character and the sorting of items, for example with the alphabetical it gets worse.

The files for the inventory are here
https://github.com/MSRevive/MasterSwordRebirth/blob/dev/src/game/client/ui/ms/vgui_container.cpp
https://github.com/MSRevive/MasterSwordRebirth/blob/dev/src/game/client/ui/ms/vgui_containerlist.cpp

[tschumann]

At a glance I think a couple of things could be done to speed it up - VGUI_ContainerPanel::AddInventoryItems in vgui_container.cpp is iterating over gearSize twice. Maybe it could be done this way: std::vector<CGenericItem *> sortedItems; std::vector<CGenericItem *> sortedOther; sortedItems.reserve(gearSize); sortedOther.reserve(gearSize); for (int g = 0; g < gearSize; g++) { CGenericItem *pGearItem = player.Gear[g]; if (!FBitSet(pGearItem->MSProperties(), ITEM_CONTAINER) && pGearItem->m_Location <= ITEMPOS_HANDS) continue; if (FBitSet(pGearItem->MSProperties(), ITEM_CONTAINER)) sortedItems.push_back(pGearItem); if (!FBitSet(pGearItem->MSProperties(), ITEM_CONTAINER)) sortedOther.push_back(pGearItem); } Then add the two vectors together which might be quicker. Maybe pGearItem->MSProperties() can be cached too. And maybe the subsequent for loop could be moved around like this: for (int i = 0; i < sorted.size(); i++) { CGenericItem *pGearItem = sorted[i]; const auto props = pGearItem->MSProperties(); // cache property lookup GearItem.IsContainer = FBitSet(props, ITEM_CONTAINER) ? true : false; if (GearItem.IsContainer) { GearItem.Name = pGearItem->DisplayName(); GearItem.ID = pGearItem->m_iId; pGearItemButton = m_GearPanel->AddGearItem(GearItem); const int itemCount = pGearItem->Container_ItemCount(); for (int j = 0; j < itemCount; j++) { containeritem_t vNewItem = containeritem_t(pGearItem->Container_GetItem(i)); pGearItemButton->m_ItemContainer->AddItem(vNewItem); } } } Sorry for the formatting - doing this from email.

…

On Fri, 20 Feb 2026 at 09:14, Saint Wish ***@***.***> wrote: *SaintWish* created an issue (MSRevive/MasterSwordRebirth#354) <#354> It seems to be caused by how many items you have on your character and the sorting of items, for example with the alphabetical it gets worse. The files for the inventory are here https://github.com/MSRevive/MasterSwordRebirth/blob/dev/src/game/client/ui/ms/vgui_container.cpp https://github.com/MSRevive/MasterSwordRebirth/blob/dev/src/game/client/ui/ms/vgui_containerlist.cpp — Reply to this email directly, view it on GitHub <#354>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA34IYVMEF5F57DP4IL3RPD4MY7VTAVCNFSM6AAAAACVYHND66VHI2DSMVQWIX3LMV43ASLTON2WKOZTHE3DKNRRG43DQMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[SaintWish]

Thanks! That's a good idea I'll try it out.