trigger_teleport "Pushables" flag 4 broken.

[frendship-loost]

Title, to be fair, this is also broken in regular Half-Life. The intention is that trigger_teleport, combined with player-exclusion flags, will only affect pushables (func_pushable) sent into its bounds, if the master key+value permits. Maybe this is an entity fix included with one of the bugfixed branches of goldsrc? I do not know.

[tschumann]

Looks like trigger_teleport doesn't support any spawn flags - maybe it was someone just copy+pasting in the .fgd file?

[frendship-loost]

I think all of the other spawnflags work. And, "Pushables" flag works on some other trigger such as trigger_once and trigger_multiple. But, it is specifically broken for trigger_teleport (I am not sure about trigger_hurt). I don't totally understand the structure of the hl codebase, but almost(or all?) of the trigger_ entity functionality is built in triggers.cpp ?

ref:
https://github.com/MSRevive/MasterSwordRebirth/blob/a8931f3a64f813d3b098b18afbbe1d0626c98266/src/game/server/triggers.cpp

[tschumann]

Ah, I see now yeah - looks like SF_TRIGGER_PUSHABLES is only supported by trigger_multiple even though it's kind of implied that all trigger_ entities support it.

[tschumann]

Still needs testing but I've pushed #285

[tschumann]

Hm, I wonder if this wasn't done for a reason? The flag "works" in that the item goes through the teleporter, but doesn't appear at the other end. Some investigation required...

[tschumann]

Alright, something to look into: https://twhl.info/thread/view/21036?page=last

I suspected it might be ending up at (0, 0, 0) but it was probably under the floor in my test map.