From 80cb8f1e51db3730dc11dab2233a14ba2ff2be41 Mon Sep 17 00:00:00 2001 From: Matthew Fluet Date: Fri, 2 Jan 2026 16:28:11 -0500 Subject: [PATCH 1/6] Simplify binary release suffix in binary-release workflow --- .github/workflows/binary-release-single.yml | 12 ++--- .github/workflows/binary-release.yml | 58 ++++++++++----------- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/.github/workflows/binary-release-single.yml b/.github/workflows/binary-release-single.yml index 26634c390..e8e415bc2 100644 --- a/.github/workflows/binary-release-single.yml +++ b/.github/workflows/binary-release-single.yml @@ -24,7 +24,7 @@ on: mlton-compile-args: required: false type: string - mlton-binary-release-suffix: + mlton-binary-release-suffix-xtra: required: false type: string workflow_call: @@ -50,7 +50,7 @@ on: mlton-compile-args: required: false type: string - mlton-binary-release-suffix: + mlton-binary-release-suffix-xtra: required: false type: string @@ -65,7 +65,7 @@ jobs: env: MLTON_VERSION: ${{ inputs.mlton-version }} - RUNNER: ${{ inputs.runner }} + MLTON_BINARY_RELEASE_SUFFIX: ".${{ inputs.runner }}${{ inputs.msystem && format('_msys2_{0}', inputs.msystem) || '' }}${{ inputs.mlton-binary-release-suffix-xtra && format('_{0}', inputs.mlton-binary-release-suffix-xtra) || '' }}" steps: - name: Configure git @@ -73,7 +73,7 @@ jobs: shell: bash - name: Install msys2 (windows) - if: ${{ startsWith(inputs.runner, 'windows') }} + if: ${{ runner.os == 'Windows' }} uses: msys2/setup-msys2@v2 with: msystem: ${{ inputs.msystem }} @@ -111,8 +111,8 @@ jobs: OLD_MLTON_COMPILE_ARGS="${{ inputs.old-mlton-compile-args }}" \ MLTON_RUNTIME_ARGS="ram-slop 0.90 ${{ inputs.mlton-runtime-args }}" \ MLTON_COMPILE_ARGS="${{ inputs.mlton-compile-args }}" \ - $( if [[ -n "$WITH_GMP_DIR" ]]; then echo "WITH_GMP_DIR=$WITH_GMP_DIR"; fi ) \ - MLTON_BINARY_RELEASE_SUFFIX="${{ inputs.mlton-binary-release-suffix }}" \ + ${{ env.WITH_GMP_DIR && format('WITH_GMP_DIR={0}', env.WITH_GMP_DIR) || '' }} \ + MLTON_BINARY_RELEASE_SUFFIX="${{ env.MLTON_BINARY_RELEASE_SUFFIX }}" \ binary-release - name: Upload binary release diff --git a/.github/workflows/binary-release.yml b/.github/workflows/binary-release.yml index 6be08f5e6..bffe23c25 100644 --- a/.github/workflows/binary-release.yml +++ b/.github/workflows/binary-release.yml @@ -19,87 +19,87 @@ jobs: matrix: include: - runner: "ubuntu-24.04" - mlton-binary-release-suffix: ".${RUNNER}_glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" + mlton-binary-release-suffix-xtra: "glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" - runner: "ubuntu-24.04" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "ubuntu-22.04" - mlton-binary-release-suffix: ".${RUNNER}_glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" + mlton-binary-release-suffix-xtra: "glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" - runner: "ubuntu-22.04" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "ubuntu-24.04-arm" - mlton-binary-release-suffix: ".${RUNNER}_glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" + mlton-binary-release-suffix-xtra: "glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" - runner: "ubuntu-24.04-arm" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "ubuntu-22.04-arm" - mlton-binary-release-suffix: ".${RUNNER}_glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" + mlton-binary-release-suffix-xtra: "glibc$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC__ (.*);\\1;p').$(cc -dM -E - <<< '#include ' | sed -En 's;#define __GLIBC_MINOR__ (.*);\\1;p')" - runner: "ubuntu-22.04-arm" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "macos-15-intel" - mlton-binary-release-suffix: ".${RUNNER}_gmp-homebrew" + mlton-binary-release-suffix-xtra: "gmp-homebrew" - runner: "macos-15-intel" mlton-compile-args: "-gmp-link-opt $(brew --prefix)/lib/libgmp.a" - mlton-binary-release-suffix: ".${RUNNER}_gmp-static" + mlton-binary-release-suffix-xtra: "gmp-static" - runner: "macos-14" - mlton-binary-release-suffix: ".${RUNNER}_gmp-homebrew" + mlton-binary-release-suffix-xtra: "gmp-homebrew" - runner: "macos-14" mlton-compile-args: "-gmp-link-opt $(brew --prefix)/lib/libgmp.a" - mlton-binary-release-suffix: ".${RUNNER}_gmp-static" + mlton-binary-release-suffix-xtra: "gmp-static" - runner: "macos-15" - mlton-binary-release-suffix: ".${RUNNER}_gmp-homebrew" + mlton-binary-release-suffix-xtra: "gmp-homebrew" - runner: "macos-15" mlton-compile-args: "-gmp-link-opt $(brew --prefix)/lib/libgmp.a" - mlton-binary-release-suffix: ".${RUNNER}_gmp-static" + mlton-binary-release-suffix-xtra: "gmp-static" - runner: "macos-26" - mlton-binary-release-suffix: ".${RUNNER}_gmp-homebrew" + mlton-binary-release-suffix-xtra: "gmp-homebrew" - runner: "macos-26" mlton-compile-args: "-gmp-link-opt $(brew --prefix)/lib/libgmp.a" - mlton-binary-release-suffix: ".${RUNNER}_gmp-static" + mlton-binary-release-suffix-xtra: "gmp-static" - runner: "windows-2025" msystem: "mingw64" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}" + mlton-binary-release-suffix-xtra: "" - runner: "windows-2025" msystem: "mingw64" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "windows-2025" msystem: "ucrt64" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}" + mlton-binary-release-suffix-xtra: "" - runner: "windows-2025" msystem: "ucrt64" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "windows-2025" msystem: "clang64" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}" + mlton-binary-release-suffix-xtra: "" - runner: "windows-2025" msystem: "clang64" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "windows-2022" msystem: "mingw64" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}" + mlton-binary-release-suffix-xtra: "" - runner: "windows-2022" msystem: "mingw64" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "windows-2022" msystem: "ucrt64" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}" + mlton-binary-release-suffix-xtra: "" - runner: "windows-2022" msystem: "ucrt64" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}_static" + mlton-binary-release-suffix-xtra: "static" - runner: "windows-2022" msystem: "clang64" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}" + mlton-binary-release-suffix-xtra: "" - runner: "windows-2022" msystem: "clang64" mlton-compile-args: "-link-opt -static" - mlton-binary-release-suffix: ".${RUNNER}_msys2_${MSYSTEM}_static" + mlton-binary-release-suffix-xtra: "static" uses: ./.github/workflows/binary-release-single.yml with: mlton-version: ${{ inputs.mlton-version }} @@ -109,5 +109,5 @@ jobs: old-mlton-compile-args: ${{ matrix.old-mlton-compile-args }} mlton-runtime-args: ${{ matrix.mlton-runtime-args }} mlton-compile-args: ${{ matrix.mlton-compile-args }} - mlton-binary-release-suffix: ${{ matrix.mlton-binary-release-suffix }} + mlton-binary-release-suffix-xtra: ${{ matrix.mlton-binary-release-suffix-xtra }} secrets: inherit From 62b3e7a226ec1fdb57028a7e3c6771bdcfb2d8f8 Mon Sep 17 00:00:00 2001 From: Matthew Fluet Date: Fri, 2 Jan 2026 17:05:08 -0500 Subject: [PATCH 2/6] Evaluate MLTON_BINARY_RELEASE_SUFFIX once in binary-release workflow --- .github/workflows/binary-release-single.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/binary-release-single.yml b/.github/workflows/binary-release-single.yml index e8e415bc2..7515dfb45 100644 --- a/.github/workflows/binary-release-single.yml +++ b/.github/workflows/binary-release-single.yml @@ -65,9 +65,12 @@ jobs: env: MLTON_VERSION: ${{ inputs.mlton-version }} - MLTON_BINARY_RELEASE_SUFFIX: ".${{ inputs.runner }}${{ inputs.msystem && format('_msys2_{0}', inputs.msystem) || '' }}${{ inputs.mlton-binary-release-suffix-xtra && format('_{0}', inputs.mlton-binary-release-suffix-xtra) || '' }}" steps: + - name: Evaluate MLTON_BINARY_RELEASE_SUFFIX + shell: bash + run: echo "MLTON_BINARY_RELEASE_SUFFIX=.${{ inputs.runner }}${{ inputs.msystem && format('_msys2_{0}', inputs.msystem) || '' }}${{ inputs.mlton-binary-release-suffix-xtra && format('_{0}', inputs.mlton-binary-release-suffix-xtra) || '' }}" >> $GITHUB_ENV + - name: Configure git run: git config --global core.autocrlf false shell: bash @@ -112,6 +115,7 @@ jobs: MLTON_RUNTIME_ARGS="ram-slop 0.90 ${{ inputs.mlton-runtime-args }}" \ MLTON_COMPILE_ARGS="${{ inputs.mlton-compile-args }}" \ ${{ env.WITH_GMP_DIR && format('WITH_GMP_DIR={0}', env.WITH_GMP_DIR) || '' }} \ + MLTON_VERSION="${{ env.MLTON_VERSION }}" \ MLTON_BINARY_RELEASE_SUFFIX="${{ env.MLTON_BINARY_RELEASE_SUFFIX }}" \ binary-release From 557d667f44e48d843f8a464e5c247e289394447f Mon Sep 17 00:00:00 2001 From: Matthew Fluet Date: Sat, 3 Jan 2026 09:15:50 -0500 Subject: [PATCH 3/6] Make binary-release-single workflow exit early when artifact exists --- .github/workflows/binary-release-single.yml | 52 ++++++++++++++++----- 1 file changed, 41 insertions(+), 11 deletions(-) diff --git a/.github/workflows/binary-release-single.yml b/.github/workflows/binary-release-single.yml index 7515dfb45..45a264253 100644 --- a/.github/workflows/binary-release-single.yml +++ b/.github/workflows/binary-release-single.yml @@ -24,6 +24,9 @@ on: mlton-compile-args: required: false type: string + mlton-binary-release: + required: false + type: string mlton-binary-release-suffix-xtra: required: false type: string @@ -50,6 +53,9 @@ on: mlton-compile-args: required: false type: string + mlton-binary-release: + required: false + type: string mlton-binary-release-suffix-xtra: required: false type: string @@ -65,12 +71,9 @@ jobs: env: MLTON_VERSION: ${{ inputs.mlton-version }} + MLTON_BINARY_RELEASE: ${{ inputs.mlton-binary-release || '1' }} steps: - - name: Evaluate MLTON_BINARY_RELEASE_SUFFIX - shell: bash - run: echo "MLTON_BINARY_RELEASE_SUFFIX=.${{ inputs.runner }}${{ inputs.msystem && format('_msys2_{0}', inputs.msystem) || '' }}${{ inputs.mlton-binary-release-suffix-xtra && format('_{0}', inputs.mlton-binary-release-suffix-xtra) || '' }}" >> $GITHUB_ENV - - name: Configure git run: git config --global core.autocrlf false shell: bash @@ -88,24 +91,49 @@ jobs: pacboy: >- github-cli:p + - name: Download and unpack source release + run: | + curl --fail -s -O -L https://github.com/${{ github.repository }}/releases/download/on-${{ inputs.mlton-version }}-release/mlton-${{ inputs.mlton-version }}.src.tgz + tar xzf mlton-${{ inputs.mlton-version }}.src.tgz --strip-components=1 || \ + tar xzf mlton-${{ inputs.mlton-version }}.src.tgz --strip-components=1 + rm mlton-${{ inputs.mlton-version }}.src.tgz + + - name: Evaluate environment variables + shell: bash + run: | + export MLTON_HOST_ARCH=$(./bin/host-arch) + echo "MLTON_HOST_ARCH=$MLTON_HOST_ARCH" >> $GITHUB_ENV + export MLTON_TARGET_ARCH=${MLTON_HOST_ARCH} + echo "MLTON_TARGET_ARCH=$MLTON_TARGET_ARCH" >> $GITHUB_ENV + export MLTON_HOST_OS=$(./bin/host-os) + echo "MLTON_HOST_OS=$MLTON_HOST_OS" >> $GITHUB_ENV + export MLTON_TARGET_OS=${MLTON_HOST_OS} + echo "MLTON_TARGET_OS=$MLTON_TARGET_OS" >> $GITHUB_ENV + export MLTON_BINARY_RELEASE_SUFFIX=.${{ inputs.runner }}${{ inputs.msystem && format('_msys2_{0}', inputs.msystem) || '' }}${{ inputs.mlton-binary-release-suffix-xtra && format('_{0}', inputs.mlton-binary-release-suffix-xtra) || '' }} + echo "MLTON_BINARY_RELEASE_SUFFIX=$MLTON_BINARY_RELEASE_SUFFIX" >> $GITHUB_ENV + export MLTON_BINARY_RELEASE_NAME=mlton-${MLTON_VERSION}-${MLTON_BINARY_RELEASE}.${MLTON_TARGET_ARCH}-${MLTON_TARGET_OS}${MLTON_BINARY_RELEASE_SUFFIX} + echo "MLTON_BINARY_RELEASE_NAME=${MLTON_BINARY_RELEASE_NAME}" >> $GITHUB_ENV + + - name: Check if artifact exists + run: echo MLTON_BINARY_RELEASE_ARTIFACT_EXISTS=$(gh release view --json assets -q '[.assets[] | .name | ascii_downcase | . == ("${{ env.MLTON_BINARY_RELEASE_NAME }}.tgz" | ascii_downcase)] | any' -R MLton/mlton) >> $GITHUB_ENV + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Checkout + if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} uses: actions/checkout@v6 with: + clean: false sparse-checkout: .github - name: Install bootstrap dependencies + if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} uses: ./.github/actions/install-bootstrap-dependencies with: install-llvm: false - - name: Download and unpack source release - run: | - curl --fail -s -O -L https://github.com/${{ github.repository }}/releases/download/on-${{ inputs.mlton-version }}-release/mlton-${{ inputs.mlton-version }}.src.tgz - tar xzf mlton-${{ inputs.mlton-version }}.src.tgz --strip-components=1 || true - tar xzf mlton-${{ inputs.mlton-version }}.src.tgz --strip-components=1 - rm mlton-${{ inputs.mlton-version }}.src.tgz - - name: Make binary release + if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} run: | # make binary-release PATH=$(pwd)/boot/bin:$PATH \ @@ -116,10 +144,12 @@ jobs: MLTON_COMPILE_ARGS="${{ inputs.mlton-compile-args }}" \ ${{ env.WITH_GMP_DIR && format('WITH_GMP_DIR={0}', env.WITH_GMP_DIR) || '' }} \ MLTON_VERSION="${{ env.MLTON_VERSION }}" \ + MLTON_BINARY_RELEASE="${{ env.MLTON_BINARY_RELEASE }}" \ MLTON_BINARY_RELEASE_SUFFIX="${{ env.MLTON_BINARY_RELEASE_SUFFIX }}" \ binary-release - name: Upload binary release + if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} run: gh release upload on-${{ inputs.mlton-version }}-release mlton-${{ inputs.mlton-version }}*.tgz --clobber env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From b9f7e445b4db69e41cf8e72c881f6cc9bfce2ab0 Mon Sep 17 00:00:00 2001 From: Matthew Fluet Date: Sat, 3 Jan 2026 09:27:13 -0500 Subject: [PATCH 4/6] Perform checkout before download and unpack source release The checkout action deletes the contents of the working directory, so must be done before downloading and unpacking the source release. --- .github/workflows/binary-release-single.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/binary-release-single.yml b/.github/workflows/binary-release-single.yml index 45a264253..31b1063e5 100644 --- a/.github/workflows/binary-release-single.yml +++ b/.github/workflows/binary-release-single.yml @@ -91,6 +91,12 @@ jobs: pacboy: >- github-cli:p + - name: Checkout + if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} + uses: actions/checkout@v6 + with: + sparse-checkout: .github + - name: Download and unpack source release run: | curl --fail -s -O -L https://github.com/${{ github.repository }}/releases/download/on-${{ inputs.mlton-version }}-release/mlton-${{ inputs.mlton-version }}.src.tgz @@ -114,18 +120,11 @@ jobs: export MLTON_BINARY_RELEASE_NAME=mlton-${MLTON_VERSION}-${MLTON_BINARY_RELEASE}.${MLTON_TARGET_ARCH}-${MLTON_TARGET_OS}${MLTON_BINARY_RELEASE_SUFFIX} echo "MLTON_BINARY_RELEASE_NAME=${MLTON_BINARY_RELEASE_NAME}" >> $GITHUB_ENV - - name: Check if artifact exists + - name: Check if binary release artifact exists run: echo MLTON_BINARY_RELEASE_ARTIFACT_EXISTS=$(gh release view --json assets -q '[.assets[] | .name | ascii_downcase | . == ("${{ env.MLTON_BINARY_RELEASE_NAME }}.tgz" | ascii_downcase)] | any' -R MLton/mlton) >> $GITHUB_ENV env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Checkout - if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} - uses: actions/checkout@v6 - with: - clean: false - sparse-checkout: .github - - name: Install bootstrap dependencies if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} uses: ./.github/actions/install-bootstrap-dependencies From 84e43d0c64434f5e75f58415dbc1e2308af61e10 Mon Sep 17 00:00:00 2001 From: Matthew Fluet Date: Sat, 3 Jan 2026 09:28:56 -0500 Subject: [PATCH 5/6] Make source-release workflow exit early when artifact exists --- .github/workflows/source-release.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.github/workflows/source-release.yml b/.github/workflows/source-release.yml index db577043f..2a16ecf37 100644 --- a/.github/workflows/source-release.yml +++ b/.github/workflows/source-release.yml @@ -15,17 +15,33 @@ on: jobs: source-release: runs-on: ubuntu-24.04 + + env: + MLTON_VERSION: ${{ inputs.mlton-version }} + steps: + - name: Check if source release artifact exists + run: echo MLTON_SOURCE_RELEASE_ARTIFACT_EXISTS=$(gh release view --json assets -q '[.assets[] | .name | ascii_downcase | . == ("mlton-${{ env.MLTON_VERSION }}.src.tgz" | ascii_downcase)] | any' -R MLton/mlton) >> $GITHUB_ENV + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Checkout + if: ${{ env.MLTON_SOURCE_RELEASE_ARTIFACT_EXISTS != 'true' }} uses: actions/checkout@v6 with: ref: on-${{ inputs.mlton-version }}-release fetch-depth: 0 + - name: Install guide dependencies + if: ${{ env.MLTON_SOURCE_RELEASE_ARTIFACT_EXISTS != 'true' }} uses: ./.github/actions/install-guide-dependencies + - name: Make source release + if: ${{ env.MLTON_SOURCE_RELEASE_ARTIFACT_EXISTS != 'true' }} run: make MLTON_VERSION="${{ inputs.mlton-version }}" source-release + - name: Upload source release + if: ${{ env.MLTON_SOURCE_RELEASE_ARTIFACT_EXISTS != 'true' }} run: gh release upload on-${{ inputs.mlton-version }}-release mlton-${{ inputs.mlton-version }}.src.tgz --clobber env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 47fce360dc98a313397f9b3728d2407af43ecf9d Mon Sep 17 00:00:00 2001 From: Matthew Fluet Date: Sat, 3 Jan 2026 09:31:38 -0500 Subject: [PATCH 6/6] Don't clobber existing assets in release workflows --- .github/workflows/binary-release-single.yml | 2 +- .github/workflows/source-release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/binary-release-single.yml b/.github/workflows/binary-release-single.yml index 31b1063e5..92a9a69df 100644 --- a/.github/workflows/binary-release-single.yml +++ b/.github/workflows/binary-release-single.yml @@ -149,6 +149,6 @@ jobs: - name: Upload binary release if: ${{ env.MLTON_BINARY_RELEASE_ARTIFACT_EXISTS != 'true' }} - run: gh release upload on-${{ inputs.mlton-version }}-release mlton-${{ inputs.mlton-version }}*.tgz --clobber + run: gh release upload on-${{ inputs.mlton-version }}-release mlton-${{ inputs.mlton-version }}*.tgz env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/source-release.yml b/.github/workflows/source-release.yml index 2a16ecf37..f80e16922 100644 --- a/.github/workflows/source-release.yml +++ b/.github/workflows/source-release.yml @@ -42,6 +42,6 @@ jobs: - name: Upload source release if: ${{ env.MLTON_SOURCE_RELEASE_ARTIFACT_EXISTS != 'true' }} - run: gh release upload on-${{ inputs.mlton-version }}-release mlton-${{ inputs.mlton-version }}.src.tgz --clobber + run: gh release upload on-${{ inputs.mlton-version }}-release mlton-${{ inputs.mlton-version }}.src.tgz env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}