Deleting post with attached unconfirmed notifications leaves them in limbo

[lamnatos]

Recently I accidentally saved an image in my shake. I realized because someone liked it and I got a notification for it. I deleted the post without bothering to confirm the notification.

Now the post is gone but the notification counter remains on the top of the page. Tapping Show Notification removes the whole box but the counter remains and the box returns when I refresh the page.

Counter and box

Counter without box

[smallsaucepan]

It appears the function that displays the "Show 1 notification" box does not check to see if the object associated with an undeleted notification has itself been deleted. The function that displays the contents of the box though (empty in this case) does filter out notifications whose associated objects have been deleted.

Cleanest choice would be to change first function to also filter on deleted related objects, so nothing is displayed at all.

Alternative would be to go through and delete all notifications for an object (file, comment, user) when the object is deleted. Though that seems messier.

@bradchoate any thoughts?