fix: remove duplicate russia-rosstat and indonesia-bps files#79
Conversation
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM. 删除旧路径的重复文件,保留 countries/ 下的新版本。建议尽快合并。
firstdata-dev
left a comment
There was a problem hiding this comment.
Confirmed: only deletes old-path duplicates. LGTM ✅
🔍 QA Review — PR #79
|
| Index File | Old path references (will become dangling) |
|---|---|
all-sources.json |
indonesia/national/indonesia-bps.json, russia/national/russia-rosstat.json |
by-authority.json |
same |
by-domain.json |
same (multiple entries each) |
by-region.json |
same |
Meanwhile, the new countries/ paths (countries/asia/indonesia/indonesia-bps.json, countries/europe/russia/russia-rosstat.json) are not present in any index file.
After merge, the indexes would have broken references to deleted files, and the kept countries/ versions would be invisible to search.
Action needed: Update the index files to replace old paths with new countries/ paths, or regenerate the indexes.
✅ Duplicate check passed
- Confirmed
countries/versions exist and are more comprehensive (richer descriptions, more domains/tags, detailed data_content). - IDs match (
russia-rosstat,indonesia-bps) — no ID duplication after merge.
✅ Schema & format check passed
- No underscores in domains ✓
- All URLs use https ✓
- Both kept files have valid JSON structure ✓
ℹ️ URL reachability (informational)
bps.go.id— 403 (WAF/anti-bot, expected for gov sites)rosstat.gov.ru— timeout (likely geo-restricted outside Russia)
These are typical for government statistical sites and not a blocker.
Summary: Please update the index files before merge. The source file cleanup itself is correct.
PR #78 added russia-rosstat and indonesia-bps in
countries/paths, but they already existed inrussia/national/andindonesia/national/.This removes the old files (less complete) and keeps the newer
countries/versions.russia/national/russia-rosstat.json(keepcountries/europe/russia/russia-rosstat.json)indonesia/national/indonesia-bps.json(keepcountries/southeast-asia/indonesia/indonesia-bps.json)