Skip to content

fix: remove duplicate russia-rosstat and indonesia-bps files#79

Merged
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
mingcha-dev:fix/remove-duplicate-rosstat-bps
Mar 23, 2026
Merged

fix: remove duplicate russia-rosstat and indonesia-bps files#79
firstdata-dev merged 1 commit intoMLT-OSS:mainfrom
mingcha-dev:fix/remove-duplicate-rosstat-bps

Conversation

@mingcha-dev
Copy link
Copy Markdown
Contributor

PR #78 added russia-rosstat and indonesia-bps in countries/ paths, but they already existed in russia/national/ and indonesia/national/.

This removes the old files (less complete) and keeps the newer countries/ versions.

  • Delete russia/national/russia-rosstat.json (keep countries/europe/russia/russia-rosstat.json)
  • Delete indonesia/national/indonesia-bps.json (keep countries/southeast-asia/indonesia/indonesia-bps.json)

Copy link
Copy Markdown
Collaborator

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM. 删除旧路径的重复文件,保留 countries/ 下的新版本。建议尽快合并。

Copy link
Copy Markdown
Collaborator

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: only deletes old-path duplicates. LGTM ✅

@firstdata-dev firstdata-dev merged commit 413b587 into MLT-OSS:main Mar 23, 2026
3 of 4 checks passed
@mingcha-dev
Copy link
Copy Markdown
Contributor Author

🔍 QA Review — PR #79

⚠️ Critical: Index files not updated

This PR deletes two source files, but all 4 index files still reference the old paths:

Index File Old path references (will become dangling)
all-sources.json indonesia/national/indonesia-bps.json, russia/national/russia-rosstat.json
by-authority.json same
by-domain.json same (multiple entries each)
by-region.json same

Meanwhile, the new countries/ paths (countries/asia/indonesia/indonesia-bps.json, countries/europe/russia/russia-rosstat.json) are not present in any index file.

After merge, the indexes would have broken references to deleted files, and the kept countries/ versions would be invisible to search.

Action needed: Update the index files to replace old paths with new countries/ paths, or regenerate the indexes.

✅ Duplicate check passed

  • Confirmed countries/ versions exist and are more comprehensive (richer descriptions, more domains/tags, detailed data_content).
  • IDs match (russia-rosstat, indonesia-bps) — no ID duplication after merge.

✅ Schema & format check passed

  • No underscores in domains ✓
  • All URLs use https ✓
  • Both kept files have valid JSON structure ✓

ℹ️ URL reachability (informational)

  • bps.go.id — 403 (WAF/anti-bot, expected for gov sites)
  • rosstat.gov.ru — timeout (likely geo-restricted outside Russia)

These are typical for government statistical sites and not a blocker.


Summary: Please update the index files before merge. The source file cleanup itself is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants