Skip to content

move proxy router cmd args to env variables #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srt0422 wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

move proxy router cmd args to env variables #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b59509
move proxy router cmd args to env variables
srt0422 Nov 28, 2023
0bba614
add variables to actions
srt0422 Nov 28, 2023
912b5f1
output variable values for traceability
srt0422 Nov 28, 2023
4c42588
Merge branch 'dev' into proxy-router-cmd-args
srt0422 Nov 28, 2023
e48ff86
Merge branch 'dev' into proxy-router-cmd-args
srt0422 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/auto-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ jobs:
SYMBOL_LMR: ${{ vars.SYMBOL_LMR }}
TITAN_LIGHTNING_DASHBOARD: ${{ vars.TITAN_LIGHTNING_DASHBOARD }}
TITAN_LIGHTNING_POOL: ${{ vars.TITAN_LIGHTNING_POOL }}

HASHRATE_ERROR_THRESHOLD: ${{vars.HASHRATE_ERROR_THRESHOLD}}
HASHRATE_CYCLE_DURATION: ${{vars.HASHRATE_CYCLE_DURATION}}
HASHRATE_SHARE_TIMEOUT: ${{vars.HASHRATE_SHARE_TIMEOUT}}
HASHRATE_VALIDATION_START_TIMEOUT: ${{vars.HASHRATE_VALIDATION_START_TIMEOUT}}
HASHRATE_VALIDATION_GRACE_DURATION: ${{vars.HASHRATE_VALIDATION_GRACE_DURATION}}

LOG_LEVEL_APP: ${{vars.LOG_LEVEL_APP}}
LOG_LEVEL_SCHEDULER: ${{vars.LOG_LEVEL_SCHEDULER}}
LOG_LEVEL_PROXY: ${{vars.LOG_LEVEL_PROXY}}
LOG_LEVEL_CONNECTION: ${{vars.LOG_LEVEL_CONNECTION}}
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -123,6 +134,7 @@ jobs:
fi
fi
done
cat .env
shell: bash
- name: Fetch latest Proxy Router
run: |
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/auto-release-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,19 @@ jobs:
SYMBOL_LMR: ${{ vars.SYMBOL_LMR }}
TITAN_LIGHTNING_DASHBOARD: ${{ vars.TITAN_LIGHTNING_DASHBOARD }}
TITAN_LIGHTNING_POOL: ${{ vars.TITAN_LIGHTNING_POOL }}

HASHRATE_ERROR_THRESHOLD: ${{vars.HASHRATE_ERROR_THRESHOLD}}
HASHRATE_CYCLE_DURATION: ${{vars.HASHRATE_CYCLE_DURATION}}
HASHRATE_SHARE_TIMEOUT: ${{vars.HASHRATE_SHARE_TIMEOUT}}
HASHRATE_VALIDATION_START_TIMEOUT: ${{vars.HASHRATE_VALIDATION_START_TIMEOUT}}
HASHRATE_VALIDATION_GRACE_DURATION: ${{vars.HASHRATE_VALIDATION_GRACE_DURATION}}

LOG_LEVEL_APP: ${{vars.LOG_LEVEL_APP}}
LOG_LEVEL_SCHEDULER: ${{vars.LOG_LEVEL_SCHEDULER}}
LOG_LEVEL_PROXY: ${{vars.LOG_LEVEL_PROXY}}
LOG_LEVEL_CONNECTION: ${{vars.LOG_LEVEL_CONNECTION}}


steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -129,6 +142,7 @@ jobs:
fi
fi
done
cat .env
shell: bash
- name: Fetch latest Proxy Router
run: |
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/auto-release-stg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ jobs:
SYMBOL_LMR: ${{ vars.SYMBOL_LMR }}
TITAN_LIGHTNING_DASHBOARD: ${{ vars.TITAN_LIGHTNING_DASHBOARD }}
TITAN_LIGHTNING_POOL: ${{ vars.TITAN_LIGHTNING_POOL }}

HASHRATE_ERROR_THRESHOLD: ${{vars.HASHRATE_ERROR_THRESHOLD}}
HASHRATE_CYCLE_DURATION: ${{vars.HASHRATE_CYCLE_DURATION}}
HASHRATE_SHARE_TIMEOUT: ${{vars.HASHRATE_SHARE_TIMEOUT}}
HASHRATE_VALIDATION_START_TIMEOUT: ${{vars.HASHRATE_VALIDATION_START_TIMEOUT}}
HASHRATE_VALIDATION_GRACE_DURATION: ${{vars.HASHRATE_VALIDATION_GRACE_DURATION}}

LOG_LEVEL_APP: ${{vars.LOG_LEVEL_APP}}
LOG_LEVEL_SCHEDULER: ${{vars.LOG_LEVEL_SCHEDULER}}
LOG_LEVEL_PROXY: ${{vars.LOG_LEVEL_PROXY}}
LOG_LEVEL_CONNECTION: ${{vars.LOG_LEVEL_CONNECTION}}
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down Expand Up @@ -129,6 +140,7 @@ jobs:
fi
fi
done
cat .env
shell: bash
- name: Fetch latest Proxy Router
run: |
Expand Down
24 changes: 12 additions & 12 deletions public/main/client/proxyRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,18 @@ const runProxyRouter = (config) => {
`--contract-address=${config.cloneFactoryAddress}`,
`--eth-node-address=${config.wsApiUrl}`,

"--miner-share-timeout=10m",
// "--miner-vetting-duration=5m",

"--hashrate-error-threshold=0.05",
"--hashrate-cycle-duration=5m",

"--hashrate-share-timeout=120m",

"--log-level-app=info",
"--log-level-scheduler=info",
"--log-level-proxy=info",
"--log-level-connection=info",
`--miner-share-timeout=${process.env.MINER_SHARE_TIMEOUT}`,

`--hashrate-error-threshold=${process.env.HASHRATE_ERROR_THRESHOLD}`,
`--hashrate-cycle-duration=${process.env.HASHRATE_CYCLE_DURATION}`,
`--hashrate-share-timeout=${process.env.HASHRATE_SHARE_TIMEOUT}`,
`--hashrate-validation-start-timeout=${process.env.HASHRATE_VALIDATION_START_TIMEOUT}`,
`--hashrate-validation-grace-duration=${process.env.HASHRATE_VALIDATION_GRACE_DURATION}`,

`--log-level-app=${process.env.LOG_LEVEL_APP}`,
`--log-level-scheduler=${process.env.LOG_LEVEL_SCHEDULER}`,
`--log-level-proxy=${process.env.LOG_LEVEL_PROXY}`,
`--log-level-connection=${process.env.LOG_LEVEL_CONNECTION}`,
`--log-folder-path=${app.getPath("logs")}/`,

`--wallet-private-key=${config.privateKey}`,
Copy link

@codereviewbot-ai codereviewbot-ai bot Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private key is being passed as a command line argument. This is a security risk because command line arguments can be viewed by any user on the system using commands like 'ps'. It's also possible that the command line arguments could be logged somewhere, exposing the private key.

Instead of passing sensitive data like private keys as command line arguments, consider using a more secure method. For example, you could read the private key from a file with appropriate permissions, or use environment variables if the environment is secure and isolated.

Copy link

@codereviewbot-ai codereviewbot-ai bot Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private key is being passed as a command line argument. This is a security risk because command line arguments can be viewed by any user on the system using commands like 'ps'. It's also possible that the command line arguments could be logged somewhere, exposing the private key.

Instead of passing sensitive data like private keys as command line arguments, consider using a more secure method. For example, you could read the private key from a file that has strict permissions, or use environment variables if you ensure they are not logged or exposed in other ways.

Copy link

@codereviewbot-ai codereviewbot-ai bot Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The private key is being passed as a command line argument. This is a security risk because command line arguments can be viewed by any user on the system using commands like ps or by inspecting the /proc filesystem. It's also possible that the command line arguments could be logged by the system or by third-party monitoring tools, which would expose the private key.

Instead of passing sensitive data like private keys as command line arguments, consider using a more secure method. For example, you could read the private key from a file with appropriate permissions, or use an environment variable. If you use an environment variable, make sure it's not logged or exposed in other ways.

Expand Down