Compile error: Invalid operands to binary expression

[YasinH]

I know this repo hasn't been updated since couple years but I was curious and wanted to compile it on mac. After fixing bunch of compile errors, this last one is remaining! Any idea what's causing it?

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/functional:678:21: error: invalid
      operands to binary expression ('const VDBVolumeSpec' and 'const VDBVolumeSpec')
        {return __x == __y;}
                ~~~ ^  ~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:513:17: note: in
      instantiation of member function 'std::__1::equal_to<VDBVolumeSpec>::operator()' requested here
        {return static_cast<const _Pred&>(*this)(__x.__get_value().first, __y);}
                ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__hash_table:2119:21: note: in
      instantiation of member function 'std::__1::__unordered_map_equal<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::equal_to<VDBVolumeSpec>, true>::operator()' requested here
                if (key_eq()(__nd->__upcast()->__value_, __k))
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__hash_table:1130:14: note: in
      instantiation of function template specialization 'std::__1::__hash_table<std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::__unordered_map_hasher<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::hash<VDBVolumeSpec>, true>, std::__1::__unordered_map_equal<VDBVolumeSpec,
      std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange>, std::__1::equal_to<VDBVolumeSpec>, true>,
      std::__1::allocator<std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange> > >::__emplace_unique_key_args<VDBVolumeSpec,
      std::__1::pair<const VDBVolumeSpec, VolumeCache::BufferRange> >' requested here
      return __emplace_unique_key_args(_NodeTypes::__get_key(__x), _VSTD::move(__x));
             ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:1043:26: note: in
      instantiation of member function 'std::__1::__hash_table<std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange>,
      std::__1::__unordered_map_hasher<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec, VolumeCache::BufferRange>,
      std::__1::hash<VDBVolumeSpec>, true>, std::__1::__unordered_map_equal<VDBVolumeSpec, std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange>, std::__1::equal_to<VDBVolumeSpec>, true>, std::__1::allocator<std::__1::__hash_value_type<VDBVolumeSpec,
      VolumeCache::BufferRange> > >::__insert_unique' requested here
        {return __table_.__insert_unique(_VSTD::move(__x));}
                         ^
/Users/Yasin/dev/openvdb-render/plugin/vdb_sliced_display.cpp:626:18: note: in instantiation of member function
      'std::__1::unordered_map<VDBVolumeSpec, VolumeCache::BufferRange, std::__1::hash<VDBVolumeSpec>, std::__1::equal_to<VDBVolumeSpec>,
      std::__1::allocator<std::__1::pair<const VDBVolumeSpec, VolumeCache::BufferRange> > >::insert' requested here
    m_buffer_map.insert({spec, buffer_range}).first;
                 ^
/Users/Yasin/dev/openvdb-render/plugin/vdb_sliced_display.cpp:519:24: note: in instantiation of function template specialization
      'VolumeCache::allocate<half>' requested here
    void* buffer_ptr = allocate<RealType>(spec);
                       ^
/Users/Yasin/dev/openvdb-render/plugin/vdb_sliced_display.cpp:483:9: note: in instantiation of function template specialization
      'VolumeCache::getVolume<half>' requested here
        getVolume<half>(spec, output);
        ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/utility:580:1: note: candidate
      template ignored: could not match 'pair<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(const pair<_T1,_T2>& __x, const pair<_T1,_T2>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:712:1: note: candidate
      template ignored: could not match 'reverse_iterator<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const reverse_iterator<_Iter1>& __x, const reverse_iterator<_Iter2>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:941:1: note: candidate
      template ignored: could not match 'istream_iterator<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2, type-parameter-0-3>'
      against 'const VDBVolumeSpec'
operator==(const istream_iterator<_Tp, _CharT, _Traits, _Distance>& __x,
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1045:6: note: candidate
      template ignored: could not match 'istreambuf_iterator<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
bool operator==(const istreambuf_iterator<_CharT,_Traits>& __a,
     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1153:1: note: candidate
      template ignored: could not match 'move_iterator<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const move_iterator<_Iter1>& __x, const move_iterator<_Iter2>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1525:1: note: candidate
      template ignored: could not match '__wrap_iter<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT_DEBUG
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/tuple:1122:1: note: candidate
      template ignored: could not match 'tuple<type-parameter-0-0...>' against 'const VDBVolumeSpec'
operator==(const tuple<_Tp...>& __x, const tuple<_Up...>& __y)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:1987:6: note: candidate
      template ignored: could not match 'allocator<type-parameter-0-0>' against 'const VDBVolumeSpec'
bool operator==(const allocator<_Tp>&, const allocator<_Up>&) _NOEXCEPT {return true;}
     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2964:1: note: candidate
      template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(const unique_ptr<_T1, _D1>& __x, const unique_ptr<_T2, _D2>& __y) {return __x.get() == __y.get();}
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3000:1: note: candidate
      template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(const unique_ptr<_T1, _D1>& __x, nullptr_t) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3008:1: note: candidate
      template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'const VDBVolumeSpec'
operator==(nullptr_t, const unique_ptr<_T1, _D1>& __x) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4796:1: note: candidate
      template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const shared_ptr<_Tp>& __x, const shared_ptr<_Up>& __y) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4850:1: note: candidate
      template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(const shared_ptr<_Tp>& __x, nullptr_t) _NOEXCEPT
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:4858:1: note: candidate
      template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'const VDBVolumeSpec'
operator==(nullptr_t, const shared_ptr<_Tp>& __x) _NOEXCEPT
^
1 error generated.
make[2]: *** [plugin/CMakeFiles/openvdb_render.dir/vdb_sliced_display.cpp.o] Error 1
make[1]: *** [plugin/CMakeFiles/openvdb_render.dir/all] Error 2
make: *** [all] Error 2

[sirpalee]

I updated the repo with some small updates we had over time, could you please try again with the latest commit on master, and get back to me with the results?

I also need some more information about your issue. Which version of MacOS/XCode/Maya/OpenVDB are you using?

[YasinH]

Hey Pal. Nice to hear from you!
I managed to compiled it actually, i forgot to update this ticket. I had to tweak the cmake files quite a bit for it to work. For example adding -DOSMac_ to CMAKE_CXX_FLAGS . I'll test out this new update that you pushed in too.

An off-topic question. What does it take to replicate the sliced representation in legacy viewport? Is it possible? It can be very rough and approximate. I've been looking for a way to simulate that type of look with legacy viewport but haven't had much luck and it seems like this tool only supports viewport 2.

[sirpalee]

Would you mind creating a PR with the change?

Regarding VP1, yes, it is possible. With VP1, you get direct access to the OpenGL viewport, so you can do whatever you want to do. Porting the sliced display would be straightforward (as the glsl code required for drawing is just simple alpha blending). The difficulty comes from properly blending your sliced volumes with the rest of the scene. VP2 offers some tools to deal with this (depth peeling based), while you are on your own with VP1.

Since we decided early on not to support VP1 (it's already hidden by default from newer Maya releases), I can't be much help. I think the long term solution would be to look into writing a Hydra Viewport plugin and an HdStorm/UsdImaging adapter. HdStorm already supports OIT, so blending would work correctly with a few slices.

[YasinH]

Sure, I'll test it on the latest update, make the changes and create the PR.

That's great if it can be ported to VP1, even if it's rough! This would be just a short-term workaround until we switch to VP2. I'm guessing I have to adjust all the functions under "Unique pointers to VP2.0 objects" and changing VolumeShader::loadShader(), right?

One more question, how is the licensing on this? There doesn't seem to be any on this repo.

[sirpalee]

Yeah, that sounds about right. Sorry, I don't have the time right now to dig into this.

Licensing: updated the licensing about 3 minutes before your comment, Apache 2 should cover all use cases.

[YasinH]

I have the changes ready and locally checked them out to a compile-fix branch. How would you like me to do the PR? If I do git push origin compile-fixes , I get error remote: Permission to LumaPictures/openvdb-render.git denied to YasinH.

[sirpalee]

No, you can't directly push to this repository. You need to fork, and create a pull request from your fork.

[YasinH]

Yeah, already did that a few days ago. Let me know if something was odd in it

…

________________________________ From: Pal Mezei <notifications@github.com> Sent: Monday, November 11, 2019 3:07:50 PM To: LumaPictures/openvdb-render <openvdb-render@noreply.github.com> Cc: YasinH <yasin.hasanian@outlook.com>; Author <author@noreply.github.com> Subject: Re: [LumaPictures/openvdb-render] Compile error: Invalid operands to binary expression (#3) No, you can't directly push to this repository. You need to fork, and create a pull request from your fork. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3?email_source=notifications&email_token=AEGMTKCXBGBF4UH7X7IVSJLQTHQUNA5CNFSM4JFQW3N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDYOKFI#issuecomment-552658197>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEGMTKBQANA22QXBMCVQKCLQTHQUNANCNFSM4JFQW3NQ>.

[sirpalee]

Ah! Sorry, I didn't notice it in my notifications. Thanks!