Alter Ice Palace ending

Alters the end of Ice Palace if the chicken isn't there so that the enemy drops a puzzle 4 item rather than puzzle 1. Avoids being able to use the other puzzle 1 item.

Author: lahm86

TRDataControl/Environment/Model/EMType.cs

@@ -96,6 +96,7 @@ public enum EMType
     ImportNonGraphicsModel = 145,
     CopySpriteSequence = 146,
     RemoveStaticCollision = 147,
+    CloneType = 148,
 
     // NOOP/Placeholder
     NOOP = 1000

TRDataControl/Environment/Model/Types/Models/EMCloneTypeFunction.cs

@@ -0,0 +1,45 @@
+using TRLevelControl.Model;
+
+namespace TRDataControl.Environment;
+
+public class EMCloneTypeFunction : BaseEMFunction
+{
+    public Dictionary<uint, uint> ModelMap { get; set; }
+    public Dictionary<uint, uint> SpriteMap { get; set; }
+
+    public override void ApplyToLevel(TR1Level level)
+        => Clone(level.Models, level.Sprites);
+
+    public override void ApplyToLevel(TR2Level level)
+        => Clone(level.Models, level.Sprites);
+
+    public override void ApplyToLevel(TR3Level level)
+        => Clone(level.Models, level.Sprites);
+
+    private void Clone<T>(TRDictionary<T, TRModel> models, TRDictionary<T, TRSpriteSequence> sprites)
+        where T : Enum
+    {
+        Clone(models, ModelMap);
+        Clone(sprites, SpriteMap);
+    }
+
+    private static void Clone<T, V>(TRDictionary<T, V> levelMap, Dictionary<uint, uint> cloneMap)
+        where T : Enum
+        where V : class, ICloneable
+    {
+        if (cloneMap == null)
+        {
+            return;
+        }
+
+        foreach (var (baseId, targetId) in cloneMap)
+        {
+            var baseType = (T)(object)baseId;
+            var targetType = (T)(object)targetId;
+            if (levelMap.TryGetValue(baseType, out var value))
+            {
+                levelMap[targetType] = (V)value.Clone();
+            }
+        }
+    }
+}

TRDataControl/Environment/Parsing/EMConverter.cs

@@ -127,6 +127,7 @@ private object ReadEMType(JObject jo)
             EMType.ImportNonGraphicsModel => JsonConvert.DeserializeObject<EMImportNonGraphicsModelFunction>(jo.ToString(), this),
             EMType.CopySpriteSequence => JsonConvert.DeserializeObject<EMCopySpriteSequenceFunction>(jo.ToString(), this),
             EMType.RemoveStaticCollision => JsonConvert.DeserializeObject<EMRemoveStaticCollisionFunction>(jo.ToString(), this),
+            EMType.CloneType => JsonConvert.DeserializeObject<EMCloneTypeFunction>(jo.ToString(), this),
 
             // NOOP
             EMType.NOOP => JsonConvert.DeserializeObject<EMPlaceholderFunction>(jo.ToString(), this),

TRRandomizerCore/Resources/TR2/Environment/ICECAVE.TR2-Environment.json

@@ -2276,16 +2276,23 @@
           }
         },
         {
-          "Comments": "Convert the CoT slot into an empty one.",
-          "EMType": 45,
-          "EntityIndex": 10,
-          "NewEntityType": 182
+          "Comments": "Clone puzzle 1 objects into puzzle 4.",
+          "EMType": 148,
+          "ModelMap": {
+            "178": 181,
+            "182": 185,
+            "186": 189
+          },
+          "SpriteMap": {
+            "174": 177
+          }
         },
         {
-          "Comments": "Reposition it to the ladder.",
-          "EMType": 44,
-          "EntityIndex": 10,
-          "TargetLocation": {
+          "Comments": "Add a slot4 at the base of the ladder.",
+          "EMType": 51,
+          "TypeID": 185,
+          "Intensity": -1,
+          "Location": {
             "X": 62976,
             "Y": 11520,
             "Z": 44544,
@@ -2294,16 +2301,11 @@
           }
         },
         {
-          "Comments": "Convert one of the CoT doors into a smaller door.",
-          "EMType": 45,
-          "EntityIndex": 16,
-          "NewEntityType": 108
-        },
-        {
-          "Comments": "Reposition it to the exit.",
-          "EMType": 44,
-          "EntityIndex": 16,
-          "TargetLocation": {
+          "Comments": "Add a door.",
+          "EMType": 51,
+          "TypeID": 108,
+          "Intensity": -1,
+          "Location": {
             "X": 62976,
             "Y": 7424,
             "Z": 43520,
@@ -2312,37 +2314,32 @@
           }
         },
         {
-          "Comments": "Convert one of the CoT doors into a mask.",
-          "EMType": 45,
-          "EntityIndex": 15,
-          "NewEntityType": 174
-        },
-        {
-          "Comments": "The chicken stole it.",
-          "EMType": 44,
-          "EntityIndex": 15,
-          "TargetLocation": {
-            "X": 66048,
-            "Y": 11520,
-            "Z": 41472,
-            "Room": 143
-          }
-        },
-        {
-          "Comments": "Make a new trigger to open the final door.",
+          "Comments": "Make a trigger to open the final door.",
           "EMType": 61,
-          "EntityLocation": 10,
+          "EntityLocation": -2,
           "Trigger": {
             "TrigType": 3,
             "Mask": 31,
-            "SwitchOrKeyRef": 10,
+            "SwitchOrKeyRef": -2,
             "Actions": [
               {
-                "Parameter": 16
+                "Parameter": -1
               }
             ]
           }
         },
+        {
+          "Comments": "Whatever the chicken is will drop a mask.",
+          "EMType": 51,
+          "TypeID": 177,
+          "Intensity": -1,
+          "Location": {
+            "X": 66048,
+            "Y": 11520,
+            "Z": 41472,
+            "Room": 143
+          }
+        },
         {
           "Comments": "Move the Talion to the new room.",
           "EMType": 44,