-
Notifications
You must be signed in to change notification settings - Fork 0
Description
IsEqualsImplemented is implemented.
I suggest making it full stack and checking == and != overloads and GetHashCode. Did I miss any method typically implemented by Visualstudio:ctrl-period-ImplementEqual?
It is hard to test that GetHashCode has an even distribution but one can at least test that every property has an effect on GetHashCode and then hope that the two(?) tested values has an effect on GetHashCode. Was that readable?
Always returning 0 is a valid implementation of GetHashCode. But we can take a decision that IsGetHashCodeImplemented requires every Change of any Property to change the GetHashCode return value. If it doesn't false is returned. If the implementation is correct anyway this implementation of IsGetHashCodeImplemented does not fit the problem.