[Bug]: The plugin is causing TPS drops

[DngYnQ]

Problem Description

Players spamming pats back and forth causes TPS to drop progressively—the more they do it, the lower it goes. They tanked my server to 10 TPS, but it recovered to 20 when they quit.

Environment

• Minecraft Version: 1.21.8
• Plugin Version: 1.21.8

[LopyMine]

Oh... We thought about this but didn't think it would actually be a problem, could you record a video showing this clearly on your server?

By the way, you can also limit the number of pats per second/minute, etc. for your players by using the ratelimit system
Here's the documentation: https://github.com/LopyMine/PatPat-Plugin/blob/master/doc/en/config.md#2-rate-limiting-ratelimit
Or just check command /patpat ratelimit ...

[nikita51bot]

The problem may be that if they do this in a crowded place, each packet is received and transmitted to the other players, and if there are 30 players in the lobby, then with each tick, and 4 players, there are 42030 = 2400 packets per second from the server (which is naturally difficult).
Can you describe in more detail how and under what circumstances this happened so that i can reproduce the problem? Average online, number of entities, etc.

[DngYnQ]

Oh... We thought about this but didn't think it would actually be a problem, could you record a video showing this clearly on your server?

By the way, you can also limit the number of pats per second/minute, etc. for your players by using the ratelimit system Here's the documentation: https://github.com/LopyMine/PatPat-Plugin/blob/master/doc/en/config.md#2-rate-limiting-ratelimit Or just check command /patpat ratelimit ...

Okay, here's the video:, and for now I'll set a temporary ratelimit to avoid further TPS drops.

[DngYnQ]

The problem may be that if they do this in a crowded place, each packet is received and transmitted to the other players, and if there are 30 players in the lobby, then with each tick, and 4 players, there are 4_20_30 = 2400 packets per second from the server (which is naturally difficult). Can you describe in more detail how and under what circumstances this happened so that i can reproduce the problem? Average online, number of entities, etc.

The server's average online is around 10-15 players, but in render distance and near me there were only 5 players who were helping demonstrate the bug.

[LopyMine]

Okay, here's the video:, and for now I'll set a temporary ratelimit to avoid further TPS drops.

So, yeah, there are just many packets for the server, if we imagine that one player does 5 pats per second (cuz there is cooldown in 4 ticks by default for one pat), then with 5 players is 25 packets per second, and with resending from server side it's around 25 * 4(maybe more) = 100 packets per second, which should be handled

Maybe my math is bad, but anyway, you could just enable ratelimit, for example, 1 pat per second
Thanks for repoting, not sure this is a bug, actually, so we probably will close this (yeah, nikita51?)

[DngYnQ]

Okay, here's the video:, and for now I'll set a temporary ratelimit to avoid further TPS drops.

So, yeah, there are just many packets for the server, if we imagine that one player does 5 pats per second (cuz there is cooldown in 4 ticks by default for one pat), then with 5 players is 25 packets per second, and with resending from server side it's around 25 * 4(maybe more) = 100 packets per second, which should be handled

Maybe my math is bad, but anyway, you could just enable ratelimit, for example, 1 pat per second Thanks for repoting, not sure this is a bug, actually, so we probably will close this (yeah, nikita51?)

Alright, thanks for the help and explanations!

[nikita51bot]

The server's average online is around 10-15 players, but in render distance and near me there were only 5 players who were helping demonstrate the bug.

Okay, I'll try to reproduce the problem and see how it can be solved (if it appears)

[nikita51bot]

https://github.com/user-attachments/assets/bef816c9-4555-4f7b-a887-ec84334cc714
Unfortunately, i was unable to reproduce such a drop in TPS, even MSPT rises rather weakly
It is surprising that your TPS begins to drop before MSPT exceeds 50
I was also unable to obtain any information about the plugin load via Spark

So, as an option, try clicking LMB instead of RMB next to each other. If TPS also drops (most likely to a lesser extent), then the problem is specifically with the packets, and that the server does not have time to send them in the allotted ticks