Add technique usage for rogue / simulated universe#355
Open
JerryLingjieMei wants to merge 15 commits intoLmeSzinc:masterfrom
Open
Add technique usage for rogue / simulated universe#355JerryLingjieMei wants to merge 15 commits intoLmeSzinc:masterfrom
JerryLingjieMei wants to merge 15 commits intoLmeSzinc:masterfrom
Conversation
…ing consistent OCR results for buttons.
…re allowing consistent OCR results for buttons." This reverts commit 5afa62b.
LmeSzinc
reviewed
Mar 5, 2024
Comment on lines
+75
to
+87
| def use_background_technique_deplete(self): | ||
| character_switch = CharacterSwitch(self.config, self.device) | ||
| character_switch.character_update() | ||
| last_character = character_switch.character_current | ||
| characters = [c for c in LIST_BACKGROUND_TECHNIQUE if c in character_switch.characters] | ||
| remains = self.map_get_technique_points() | ||
| for i, c in enumerate(characters[:remains]): | ||
| if i > 0: | ||
| character_switch.character_update() | ||
| character_switch.character_switch(c) | ||
| self.device.screenshot() | ||
| self.use_technique_(1, limit=.2, n=1) | ||
| character_switch.character_switch(last_character) |
Owner
There was a problem hiding this comment.
- character_update() was already called in character_switch_to_ranged(), reuse
self.characters - In continuous flows, there should'nt be
self.device.screenshot()calls, each method should reuse the last screenshot - Character priority is still required when emptying techniques
Contributor
Author
There was a problem hiding this comment.
The character priority is implied in Line 79.
LmeSzinc
reviewed
Mar 5, 2024
tasks/daily/use_technique.py
Outdated
Comment on lines
+11
to
+13
| def _use_technique(self, count: int, skip_first_screenshot=True): | ||
| def use_technique_(self, count: int, skip_first_screenshot=True, limit=.5, n=2): |
Owner
There was a problem hiding this comment.
no confirm timer if count==1, don't expose it
LmeSzinc
added
feature request / 功能请求
Contributor
Author
|
Ready to merge. |
|
Any update for Acheron (黄泉) please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#345 Add use of technique points for ranged characters with background skill like ruan mei in rogue mode. When in boss domain, the characters will deplete all technique points using background skills.