chore: Refactor identities controller and service

Author: tacxou

src/management/identities/identities.controller.ts

@@ -204,12 +204,14 @@ export class IdentitiesController extends AbstractController {
     @Res() res: Response,
   ): Promise<Response> {
     try {
-      const data = await this._service.findById(_id);
+      const identity = await this._service.findById(_id);
+      const data = this._service.transformNullsToString(JSON.parse(JSON.stringify(identity)));
       return res.status(HttpStatus.OK).json({
         statusCode: HttpStatus.OK,
         data,
       });
     } catch (error) {
+      console.log('error', error);
       let validations = error.validations;
       if (error instanceof BadRequestException) validations = error.getResponse();
       return res.status(HttpStatus.BAD_REQUEST).json({

src/management/identities/identities.service.ts

@@ -67,7 +67,7 @@ export class IdentitiesService extends AbstractServiceSchema {
       ]),
     });
 
-    console.log('data', data);
+    // console.log('data', data);
 
     if (!data?.inetOrgPerson?.employeeNumber || !data?.inetOrgPerson?.employeeType) {
       throw new BadRequestException(
@@ -318,7 +318,7 @@ export class IdentitiesService extends AbstractServiceSchema {
     }
   }
 
-  private transformNullsToString(obj) {
+  public transformNullsToString(obj) {
     if (obj === null) {
       return "";
     }
@@ -332,6 +332,7 @@ export class IdentitiesService extends AbstractServiceSchema {
         if (obj[key] === null) {
           obj[key] = "";
         } else if (typeof obj[key] === 'object') {
+          console.log('key', key);
           obj[key] = this.transformNullsToString(obj[key]);
         }
       }