Merge pull request #6 from BanceDev/main

LegitCamper · web-flow · commit 33d14477baa0 · 2025-04-27T18:11:20.000-06:00
crash fix when closing view
diff --git a/src/webview/basic.rs b/src/webview/basic.rs
@@ -167,14 +167,14 @@ impl<Engine: engines::Engine + Default, Message: Send + Clone + 'static> WebView
             }
             Action::CloseCurrentView => {
                 self.engine.remove_view(self.get_current_view_id());
-                self.view_ids.remove(self.get_current_view_id());
+                self.view_ids.remove(self.current_view_index);
                 if let Some(on_view_close) = &self.on_close_view {
                     tasks.push(Task::done(on_view_close.clone()));
                 }
             }
             Action::CloseView(index) => {
                 self.engine.remove_view(self.index_as_view_id(index));
-                self.view_ids.remove(self.index_as_view_id(index));
+                self.view_ids.remove(index as usize);
 
                 if let Some(on_view_close) = &self.on_close_view {
                     tasks.push(Task::done(on_view_close.clone()))

Original file line number	Diff line number	Diff line change
`@@ -167,14 +167,14 @@ impl<Engine: engines::Engine + Default, Message: Send + Clone + 'static> WebView`
`167`	`167`	`}`
`168`	`168`	`Action::CloseCurrentView => {`
`169`	`169`	`self.engine.remove_view(self.get_current_view_id());`
`170`		`- self.view_ids.remove(self.get_current_view_id());`
	`170`	`+ self.view_ids.remove(self.current_view_index);`
`171`	`171`	`if let Some(on_view_close) = &self.on_close_view {`
`172`	`172`	`tasks.push(Task::done(on_view_close.clone()));`
`173`	`173`	`}`
`174`	`174`	`}`
`175`	`175`	`Action::CloseView(index) => {`
`176`	`176`	`self.engine.remove_view(self.index_as_view_id(index));`
`177`		`- self.view_ids.remove(self.index_as_view_id(index));`
	`177`	`+ self.view_ids.remove(index as usize);`
`178`	`178`
`179`	`179`	`if let Some(on_view_close) = &self.on_close_view {`
`180`	`180`	`tasks.push(Task::done(on_view_close.clone()))`