Merge pull request #58 from LedgerHQ/fbe/fix_output_pytest_directories_for_v2

Fbe/fix output pytest directories for v2

Author: fbeutin-ledger

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.12.3] - 2025-11-06
+
+### Fixed
+
+- Fix `output_pytest_directories` option for v2 manifests
+
 ## [0.12.2] - 2025-07-21
 
 ### Fixed

src/ledgered/manifest/cli.py

@@ -256,15 +256,15 @@ def main() -> None:  # pragma: no cover
             sys.exit(2)
         test_config = repo_manifest.pytests[0]
         if isinstance(test_config, TestsConfig):
+            # Legacy format, only one possible directory to return so we return it
             display_content["tests"]["pytest_directory"] = str(test_config.pytest_directory)
         elif isinstance(test_config, PyTestsConfig):
+            # If we have several pytests, we look for the [standalone] one
             for cfg in repo_manifest.pytests:
                 assert isinstance(cfg, PyTestsConfig)
-                if "standalone" in str(cfg.directory):
+                if cfg.key == "standalone":
+                    display_content["tests"]["pytest_directory"] = str(cfg.directory)
                     break
-            assert isinstance(cfg, PyTestsConfig)
-            if "standalone" in str(cfg.directory):
-                display_content["tests"]["pytest_directory"] = str(cfg.directory)
         else:
             logger.error(
                 "This manifest contains a [pytests] field, but no [tests] field. "

tests/_data/full_correct_v2.toml

@@ -12,7 +12,7 @@ test_with_feature_activated = "TEST_FLAG_TO_SET=1"
 directory = "./unit-tests/"
 
 [pytest.standalone]
-directory = "tests/standalone"
+directory = "tests/path_to_st_tests"
 
 [pytest.swap]
 directory = "tests/swap"
@@ -25,4 +25,4 @@ testing_with_latest = [
 testing_with_prod = [
   {url = "https://github.com/LedgerHQ/app-exchange", ref = "master"},
   {url = "https://github.com/LedgerHQ/app-ethereum", ref = "master"}
-]
+]

tests/functional/test_github.py

@@ -20,7 +20,7 @@ def test_get_app(gh):
 
 def test_exchange_manifest(exchange):
     assert exchange.manifest.app.sdk == "c"
-    assert len(exchange.manifest.app.devices) == 4
+    assert len(exchange.manifest.app.devices) == 5
 
 
 def test_exchange_makefile_path(exchange):