From 305c7c3045e595d069205e96dc597d8408962110 Mon Sep 17 00:00:00 2001
From: pxpm <pxpm88@gmail.com>
Date: Fri, 13 Dec 2024 10:32:16 +0000
Subject: [PATCH 1/2] update filter stub

---
 .../Commands/Views/FilterBackpackCommand.php  | 17 ++++
 src/Console/stubs/filter.stub                 | 85 ++++++++++---------
 2 files changed, 61 insertions(+), 41 deletions(-)

diff --git a/src/Console/Commands/Views/FilterBackpackCommand.php b/src/Console/Commands/Views/FilterBackpackCommand.php
index 6fe60c9..5fe576c 100644
--- a/src/Console/Commands/Views/FilterBackpackCommand.php
+++ b/src/Console/Commands/Views/FilterBackpackCommand.php
@@ -2,6 +2,8 @@
 
 namespace Backpack\Generators\Console\Commands\Views;
 
+use Illuminate\Support\Str;
+
 class FilterBackpackCommand extends PublishOrCreateViewBackpackCommand
 {
     /**
@@ -45,4 +47,19 @@ class FilterBackpackCommand extends PublishOrCreateViewBackpackCommand
      * @var string
      */
     protected $stub = 'filter.stub';
+
+    /**
+     * Build the class with the given name.
+     *
+     * @param  string  $name
+     * @return string
+     */
+    protected function buildClass($name)
+    {
+        $name = Str::of($name)->camel()->ucfirst()->value();
+        $stub = $this->files->get($this->getStub());
+        $stub = str_replace('__FILTER_NAME__', $name, $stub);
+
+        return $stub;
+    }
 }
diff --git a/src/Console/stubs/filter.stub b/src/Console/stubs/filter.stub
index 633cb93..9bc5a37 100644
--- a/src/Console/stubs/filter.stub
+++ b/src/Console/stubs/filter.stub
@@ -1,64 +1,67 @@
-{{-- Simple Backpack CRUD filter --}}
 <li filter-name="{{ $filter->name }}"
     filter-type="{{ $filter->type }}"
     filter-key="{{ $filter->key }}"
+	filter-debounce="{{ $filter->options['debounce'] ?? 0 }}"
+	filter-init-function="{{ $filter->options['init_function'] ?? 'init__FILTER_NAME__Filter' }}"
 	class="nav-item {{ Request::get($filter->name)?'active':'' }}">
-    <a class="nav-link" href=""
-		parameter="{{ $filter->name }}"
-    	>{{ $filter->label }}</a>
+    <a class="nav-link" href="javascript:void(0);">{{ $filter->label }}</a>
   </li>
 
 
-{{-- ########################################### --}}
-{{-- Extra CSS and JS for this particular filter --}}
+@push('after_scripts')
+@bassetBlock('__FILTER_NAME__-filter.js')
+    <script>
+		// init function for simple filter
+		function init__FILTER_NAME__Filter(filter, filterNavbar) {
 
-{{-- FILTERS EXTRA JS --}}
-{{-- push things in the after_scripts section --}}
+			let filterName = filter.getAttribute('filter-name');
+			let filterKey = filter.getAttribute('filter-key');
+			let filterAnchor = filter.querySelector('a');
+			let filterDebounce = filter.getAttribute('filter-debounce');
+			let navBarId = filterNavbar.getAttribute('id');
+			let shouldUpdateUrl = true;
 
-@push('crud_list_scripts')
-    <script>
-		jQuery(document).ready(function($) {
-			$("li[filter-key={{ $filter->key }}] a").click(function(e) {
+			filterAnchor.addEventListener('click', async function(e) {
 				e.preventDefault();
 
-				var parameter = $(this).attr('parameter');
-
-		    	// behaviour for ajax table
-				var ajax_table = $("#crudTable").DataTable();
-				var current_url = ajax_table.ajax.url();
+				// get the filter value
+				let filterValue = filter.classList.contains('active') ? true : false;
 
-				if (URI(current_url).hasQuery(parameter)) {
-					var new_url = URI(current_url).removeQuery(parameter, true);
-				} else {
-					var new_url = URI(current_url).addQuery(parameter, true);
+				switch (filterValue) {
+					case true:
+						filterValue = null;
+						break;
+					default:
+						filterValue = true;
 				}
 
-				new_url = normalizeAmpersand(new_url.toString());
+				if (filterValue) {
+					filter.classList.add('active');
+				}else{
+					filter.dispatchEvent(new CustomEvent('backpack:filter:clear'));
+				} 
 
-				// replace the datatables ajax url with new_url and reload it
-				ajax_table.ajax.url(new_url).load();
+				document.dispatchEvent(new CustomEvent('backpack:filter:changed', {
+					detail: {
+						filterName: filterName, 
+						filterValue: filterValue, 
+						shouldUpdateUrl: shouldUpdateUrl,
+						debounce: filterDebounce,
 
-				// add filter to URL
-				crud.updateUrl(new_url);
-
-				// mark this filter as active in the navbar-filters
-				if (URI(new_url).hasQuery('{{ $filter->name }}', true)) {
-					$("li[filter-key={{ $filter->key }}]").removeClass('active').addClass('active');
-                    $('#remove_filters_button').removeClass('invisible');
-				}
-				else
-				{
-					$("li[filter-key={{ $filter->key }}]").trigger("filter:clear");
-				}
-			});
+					}
+				}));
+			});	
 
 			// clear filter event (used here and by the Remove all filters button)
-			$("li[filter-key={{ $filter->key }}]").on('filter:clear', function(e) {
-
-				$("li[filter-key={{ $filter->key }}]").removeClass('active');
+			filter.addEventListener('backpack:filter:clear', function(e) {
+				if(e.detail && e.detail.clearAllFilters) {
+					shouldUpdateUrl = false
+				}
+				filter.classList.remove('active');
 			});
-		});
+		};			
 	</script>
+@endBassetBlock
 @endpush
 {{-- End of Extra CSS and JS --}}
 {{-- ########################################## --}}

From e0c9f21749775464909e4ca291a4d026d26e8049 Mon Sep 17 00:00:00 2001
From: pxpm <pxpm88@gmail.com>
Date: Mon, 22 Dec 2025 11:01:55 +0000
Subject: [PATCH 2/2] update filter stub

---
 src/Console/stubs/filter.stub | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/Console/stubs/filter.stub b/src/Console/stubs/filter.stub
index 9bc5a37..133ea5d 100644
--- a/src/Console/stubs/filter.stub
+++ b/src/Console/stubs/filter.stub
@@ -18,11 +18,17 @@
 			let filterKey = filter.getAttribute('filter-key');
 			let filterAnchor = filter.querySelector('a');
 			let filterDebounce = filter.getAttribute('filter-debounce');
-			let navBarId = filterNavbar.getAttribute('id');
 			let shouldUpdateUrl = true;
 
+			// prevent duplicate event bindings when the filter view re-renders
+			if (filter.getAttribute('data-filter-initialized') === 'true') {
+				return;
+			}
+			filter.setAttribute('data-filter-initialized', 'true');
+
 			filterAnchor.addEventListener('click', async function(e) {
 				e.preventDefault();
+				shouldUpdateUrl = true;
 
 				// get the filter value
 				let filterValue = filter.classList.contains('active') ? true : false;
@@ -43,20 +49,18 @@
 
 				document.dispatchEvent(new CustomEvent('backpack:filter:changed', {
 					detail: {
-						filterName: filterName, 
-						filterValue: filterValue, 
+						filterName: filterName,
+						filterValue: filterValue,
 						shouldUpdateUrl: shouldUpdateUrl,
 						debounce: filterDebounce,
-
+						componentId: filterNavbar.getAttribute('data-component-id'),
 					}
 				}));
 			});	
 
 			// clear filter event (used here and by the Remove all filters button)
 			filter.addEventListener('backpack:filter:clear', function(e) {
-				if(e.detail && e.detail.clearAllFilters) {
-					shouldUpdateUrl = false
-				}
+				shouldUpdateUrl = !(e.detail && e.detail.clearAllFilters);
 				filter.classList.remove('active');
 			});
 		};