-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Description
Summary
The None tier fires when a PXD accession is missing title, organisms, or instruments. PRIDE's submission pipeline enforces all three as mandatory fields — every published PXD dataset has them. After scanning hundreds of live accessions (PXD000001–PXD001200 and targeted keyword searches), no published PXD accession was found with any of these fields absent.
Impact
- The
Nonetier branch intier_engine.pyis dead code for Phase 1 (PXD-only auditing against PRIDE). It is not a bug — the logic is correct
and the branch is covered by unit tests using synthetic payloads. C08integration tests cannot testNonetier against a live PXD accession. The integration test suite should acknowledge this and skip the live None test.
Tiers reachable on live PRIDE (as-of 2026)
| Tier | Reachable? | Example accession |
|---|---|---|
| Gold | ✅ | PXD075811 (14 files) |
| Silver | ✅ | PXD000001 (8 files) |
| Bronze | ✅ | PXD057701 (1070 raw-only files) |
| None | ❌ | No live PXD example exists |
| Unverifiable | ✅ | Any non-PXD accession (e.g. MSV000001) |
Why None still belongs in the model
- Phase 2+ will ingest non-PRIDE repositories (MassIVE, jPOST, iProX) whose submission pipelines may not enforce these fields.
- PRIDE's validation could theoretically produce edge cases in the future (reprocessed metadata, withdrawn-then-restored datasets).
- Unit tests exercise this branch with synthetic payloads — correctness is fully verified without a live example.
Resolution plan
- Phase 1: document as known non-testable live tier; skip it in C08.
- Phase 2: add a live None-tier example from a non-PRIDE repository, or construct a controlled synthetic endpoint for integration test harness.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request