Accordion onmouseup change events guaranteed to not fire

[thezboe]

sigplot/js/sigplot.accordion.js

Lines 429 to 451 in 5bae787

	_onDocMouseUp() {
	const Mx = this.Mx;
	// We are no longer dragging
	this.dragging = false;
	this.edge_dragging = false;
	// only emit an event if we are actually dragging
	if (!this.dragging || !this.edge_dragging) {
	return;
	}
	// Issue a slider tag event
	let evt = document.createEvent('Event');
	evt.initEvent('accordiontag', true, true);
	evt.center = this.properties.center;
	evt.width = this.properties.width;
	mx.dispatchEvent(Mx, evt);
	this.emit('change', {
	center: this.properties.center,
	width: this.properties.width
	});
	}

this.dragging and this.edge_dragging are set to false just before the if-statement that returns if one of them is false.
Furthermore, I believe the if-statement logic is incorrect. this.dragging is set to true if the center is being dragged, and this.edge_dragging is true if the edge is being dragged. They are never both true at the same time it appears, so the if-statement will always be truthy and the event never fired.

[maihde]

I agree, the `this.dragging = false;` and `this.edge_dragging = false` need to be moved after the event has fired.

…

On Tue, Oct 6, 2020 at 5:55 PM Zachary Boe ***@***.***> wrote: https://github.com/LGSInnovations/sigplot/blob/5bae7873547e8a490a691ee30c2576800e6cb81a/js/sigplot.accordion.js#L429 this.dragging and this.edge_dragging are set to false just before the if-statement that returns if one of them is false. Furthermore, I believe the if-statement logic is incorrect. this.dragging is set to true if the center is being dragged, and this.edge_dragging is true if the edge is being dragged. They are never both true at the same time it appears, so the if-statement will always be truthy and the event never fired. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#96>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYEIVKDLQW43LTAIQYZFTSJOG47ANCNFSM4SGS76EA> .

[maihde]

@thezboe I fixed this in spectriclabs@4b58015

[thezboe]

This has caused another issue with accordion events. I believe the following snippet needs to be && not || since they will never both be true. This has the result that the accordion plugin can not be dropped.

sigplot/js/sigplot.accordion.js

Line 437 in 5bae787

if (!this.dragging || !this.edge_dragging) {

[maihde]

Thanks Zach we will take a look. FYI the primary source for SigPlot has been moved to https://github.com/spectriclabs/sigplot so I recommend placing any future issues there.