Skip to content

Refactor: inherit and use BaseModel only when necessary #59

@LAMaglan

Description

@LAMaglan

Need to figure out when it is necessary to have a class inherit from BaseModel (specifically, Pokemon class).
Could be that there should be a Pokemon class (no BaseModel), and a PokemonValidator (from BaseModel).

When using BaseModel, can pass json_schema_extra to Config which will have description of each attribute. That might be useful to remember erected structure etc. of input.
But maybe it doesn't make sense in this context, since data is fetched (GET, not POST)?

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions