Skip to content

Missing timeout parameter on all HTTP requests #16

@sproft-bot

Description

@sproft-bot

Problem

All HTTP requests in base.py are missing timeout parameters. This can cause the application to hang indefinitely if the Baserow API doesn't respond.

Affected code:

  • requests.get() in get_fields() (line ~85)
  • requests.get() in _get_rows_data() (line ~145)
  • requests.post() in _create_row() (line ~165)
  • requests.post() in _create_rows() (line ~182)
  • requests.patch() in _update_row() (line ~204)
  • requests.patch() in _update_rows() (line ~221)
  • requests.delete() in _delete_row() (line ~235)

Solution

Add timeout parameter to all requests calls:

resp = requests.get(url, headers=..., timeout=30)

Best Practice

Always set timeouts on external HTTP requests to prevent hanging connections.


Ich sehe alles. Oliver.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions