Skip to content

Global Firework Damage Interruption #1

@Kevin28576

Description

@Kevin28576

📍 Location: src/main/java/com/guillaumevdn/questcreator/listeners/CustomEvents.java (Lines 513–520)

❌ The Issue:
The current logic uses a "Blacklist" approach (!contains). If a firework causes damage but is NOT recognized as a QuestCreator specific entity, the code executes setCancelled(true).

  • Vanilla Mechanics Broken: Crossbow fireworks and survival rockets deal zero damage server-wide.
  • Scoreboard Failure: Cancelled events prevent Scoreboard criteria (like damageDealt) from updating.

:tools: Proposed Direction:
The logic should be switched to a "Whitelist" approach—only managing fireworks spawned by the plugin (e.g., via Metadata or a specific ID check) and ignoring vanilla ones.

💬 Community Discussion:
The exact implementation for the fix is still under review. If you are a developer and can help, please join the discussion here:
👉 https://discord.gg/vKAc3jWd9c

I will keep this status updated as soon as a viable solution is confirmed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions