Skip to content

Fix bad function names #8

@KarlHeitmann

Description

@KarlHeitmann

There are a bunch of functions with weird, ambiguos and/or bad names. This is an issue I will never close, because I think these kind of bad names will never end. Just link the PR that address these kind of issues here, and describe in your PR what are you attending to fix. Below is a list of function names I will take note and you can take as example to refactor.

[ ] (run_wrapper)[https://github.com/KarlHeitmann/rg_explorer/blob/960bf90942896f78eee3eaf327e4fbf30b19235c/src/rip_grep/mod.rs#L93]: I introduced run_wrapper when I added the feature to edit the search_term of RipGrep struct by the src/ui/edit.rs ui. The idea was to wrap the run inside a wrapper. run function will perform the rg child process and update the Nodes of the RipGrep struct. But I don't wanted run to be called if the search_term didn't change at all. That's why I wrapped it into the run_wrapper function, run_wrapper will only execute run if search term is different than the search_term_buffer, the String that is manipulated on src/ui/edit.rs. Maybe someone has an idea for a better name to run_wrapper ? or this is unnecesary/overwhelming?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions