Skip to content

Max burn time / sufficient fuel indicator is wrong for LH2/O engines #7

@kamalmostafa

Description

@kamalmostafa

The max burn time calculation is wrong, and hence the Est. Burn (~) insufficient fuel indicator too, for engines which consume fuel mixtures of unequal density, because BetterBurnTime doesn't take fuel density into account.

This bug doesn't manifest for the stock LF/O engines only because LF and O happen to have the same density (5 kg/l) so ignoring it "works". But for engines which use an LH2/O mixture (e.g. @ChrisAdderley's CryoEngines) or any other fuel mixtures of non-homogeneous density, BetterBurnTime miscalculates the max burn time, always indicating insufficient fuel when there will actually be plenty.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions