Skip to content

fix: Extract domains from subdomains (-md) #26

@callightmn

Description

@callightmn

Hello,

I recently came across the following behavior when trying to discover subdomains of a .net.co domain (let's say example.net.co). Gotator gave me several false positives, including 99.net.co, when given a subdomain in input (let's say api.example.net.co).

This behavior seems to come from isCCSLDDomain which does not filter .net.co domains properly depending on the length of the input (sub)domain:

Image

This is because the check against ccsld (which contains "net.co" in our case) is performed by joining all the values of splitDomain excluding the first one (that's why when given example.net.co it properly filters the domain but not when given api.example.net.co).

A more robust check would be:

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions