Bug: logic in Ricco 1 includes requirements that Yoshi satisfies

[mooinglemur]

What happened?

raysfire got an impossble seed

Ricco 1: "Spawn Building Top M" contained the spray nozzle.

Requirements say ANY_SPLASHER, which includes Yoshi. Yoshi isn't available in Ricco 1. All other nozzles were in Sunshine later in logic in this particular generation.

https://github.com/Joshark/archipelago-sms/blob/main/worlds/sms/sms_regions/ricco_harbor.py#L12

I believe this should be instead SPRAY_OR_HOVER. However, SPRAY_OR_HOVER mistakenly resolves to spray or rocket: https://github.com/Joshark/archipelago-sms/blob/main/worlds/sms/sms_regions/sms_region_helper.py#L202-L205

I think every other blue coins with ANY_SPLASHER requirements in Ricco 1 should not be set as such.

I'm sure Panga and perhaps others will be sending this your way too.

What were the expected results?

Generation should not have been allowed to place the spray nozzle here unless the hover nozzle was also available.

Software

Local generation

[SomeJakeGuy]

Thank you for reporting! Will work on a fix for this over the coming days :D