Commit 8f8f632 renders `liboat_hook.so` ineffective

[JingMatrix]

Steps to reproduce/复现步骤

1. Install a dex2oat modification detector, such as
   Android-Native-Root-Detector
2. The detector shows that base.odex modification is found.

Expected behaviour/预期行为

No modification of base.odex should be detected.

Actual behaviour/实际行为

The header section dex2oat-cmdline has value:

/apex/com.android.art/bin/dex2oat64 --zip-fd=6 --zip-location=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A==/base.apk --oat-fd=7 --oat-location=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A==/oat/arm64/base.odex --output-vdex-fd=8 --swap-fd=9 --class-loader-context-fds=10:11 --class-loader-context=PCL[]{PCL[/system_ext/framework/androidx.window.extensions.jar]#PCL[/system_ext/framework/androidx.window.sidecar.jar]} --classpath-dir=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A== --input-vdex-fd=12 --instruction-set=arm64 --instruction-set-features=default --instruction-set-variant=cortex-a55 --compiler-filter=verify --compilation-reason=cmdline --compact-dex-level=none --max-image-block-size=524288 --resolve-startup-const-strings=true --generate-mini-debug-info --runtime-arg -Xtarget-sdk-version:35 --runtime-arg -Xhidden-api-policy:enabled --runtime-arg -Xms64m --runtime-arg -Xmx512m --comments=app-name:com.reveny.nativecheck,app-version-name:6.6.2,app-version-code:662,art-version:360105020 --inline-max-code-units=0

Xposed Module List/Xposed 模块列表

N/A

Magisk Module List/Magisk 模块列表

1. NeoZygisk
2. LSPosed

LSPosed version/LSPosed 版本

1.10.1 (7171)

Android version/Android 版本

16 Beta 2

Magisk version/Magisk 版本

28.1 (28100)

Riru version/Riru 版本

N/A

Version requirement/版本要求

• I am using latest debug CI version of LSPosed and enable verbose log/我正在使用最新 CI 调试版本且启用详细日志

Logs/日志

--------- beginning of main
02-17 13:11:28.324 10182 10182 W dex2oat64: Obsolete flag --compact-dex-level ignored
02-17 13:11:28.328 10182 10182 W dex2oat64: Mismatch between dex2oat instruction set features to use (ISA: Arm64 Feature string: -a53,crc,lse,fp16,dotprod,-sve) and those from CPP defines (ISA: Arm64 Feature string: -a53,-crc,-lse,-fp16,-dotprod,-sve) for the command line:
02-17 13:11:28.328 10182 10182 W dex2oat64: /apex/com.android.art/bin/dex2oat64 --zip-fd=6 --zip-location=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A==/base.apk --oat-fd=7 --oat-location=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A==/oat/arm64/base.odex --output-vdex-fd=8 --swap-fd=9 --class-loader-context-fds=10:11 --class-loader-context=PCL[]{PCL[/system_ext/framework/androidx.window.extensions.jar]#PCL[/system_ext/framework/androidx.window.sidecar.jar]} --classpath-dir=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A== --input-vdex-fd=12 --instruction-set=arm64 --instruction-set-features=default --instruction-set-variant=cortex-a55 --compiler-filter=verify --compilation-reason=cmdline --compact-dex-level=none --max-image-block-size=524288 --resolve-startup-const-strings=true --generate-mini-debug-info --runtime-arg -Xtarget-sdk-version:35 --runtime-arg -Xhidden-api-policy:enabled --runtime-arg -Xms64m --runtime-arg -Xmx512m --comments=app-name:com.reveny.nativecheck,app-version-name:6.6.2,app-version-code:662,art-version:360105020 --inline-max-code-units=0
02-17 13:11:28.329 10182 10182 I dex2oat64: /apex/com.android.art/bin/dex2oat64 --output-vdex-fd=8 --class-loader-context-fds=10:11 --class-loader-context=PCL[]{PCL[/system_ext/framework/androidx.window.extensions.jar]#PCL[/system_ext/framework/androidx.window.sidecar.jar]} --classpath-dir=/data/app/~~f_MpoDOM1y8PyEkM7kMVXQ==/com.reveny.nativecheck-bDkBkVyYntu-Wr4gKn5t_A== --input-vdex-fd=12 --compiler-filter=verify --compilation-reason=cmdline --compact-dex-level=none --max-image-block-size=524288 --resolve-startup-const-strings=true --generate-mini-debug-info --comments=app-name:com.reveny.nativecheck,app-version-name:6.6.2,app-version-code:662,art-version:360105020 --inline-max-code-units=0
02-17 13:11:28.347 10182 10182 I dex2oat64: Using CollectorTypeCMC GC.
02-17 13:11:28.522 10182 10182 I dex2oat64: dex2oat took 200.604ms (168.502ms cpu) (threads: 8) arena alloc=0B (0B) java alloc=4328KB (4432256B) native alloc=1697KB (1738560B) free=1201KB (1229872B)

[bocchi810]

OKay, I will create a PR to fix this problem

[JingMatrix]

The substring --inline-max-code-units=0 is supposed to be removed by https://github.com/JingMatrix/LSPosed/blob/master/dex2oat/src/main/cpp/oat_hook.cpp.
However, currently, it is still present in the header file of base.odex. Maybe something unexpected happens during the PLT hook.

[JingMatrix]

This bug is brought by the commit 8f8f632.