Errors being logged to stdout instead of via logging library makes it not easy to debug them

[ShadowJonathan]

I encountered this while looking at MiguelAngelLV/ha-nintendo-switch#10; the following lines do a print and then return None;

nso-api/nso_api/imink.py

Lines 40 to 42 in a89eb68

	if res.status_code != 200:
	print(f'Unexpected HTTP code "{res.status_code} {res.reason}" from imink f')
	return None

nso-api/nso_api/imink.py

Lines 58 to 60 in a89eb68

	if res.status_code != 200:
	print(f'Unexpected HTTP code "{res.status_code} {res.reason}" from imink config')
	return None

These should be using logging or the likes, with an error or a warning, since then it can bubble up to other applications, such as home assistant.

[ShadowJonathan]

Alternatively, these could be raised as exceptions, since they're nonrecoverable, and the calling library should be made aware of these problems.

[Jetsurf]

Andy and I are currently in the process of preparing an update to fix the nxapi f-token generation from the NSO 2.12.0 update.

We can get it more in-line with the rest of the code structure to behave better. Expect it to be rolled into the update coming soon.

[MiguelAngelLV]

When release the new version I will update my custom component :)

[MiguelAngelLV]

The NSO x.98 would fix this?

[Jetsurf]

Not a ton changed in the output for how iMink/NXApi returns failures (it still returns none).

At this time though, Nintendo pushed version 3.0.0 for the app, which broke f-token generation again. Just be aware that any libraries (not just ours) will be non-functional due to Nintendos changes.

[Dyr-Fenrir]

Greetings!

Just an FYI, as far as I know, there has been some major developments on the NXAPI side in the last few days, I am unsure if all is finished for third party script/clients like NSO-API, but it might be worth checking if it is possible to make your library working again.

Thank you for your time and help again, it is greatly appreciated!

[Jetsurf]

Apologies that it's been a bit since you responded Dyr-Fenrir. I did see all of the changes nxapi made to get f-token generation back online.

For the immediate short term, I unfortunately do not have the time to get this updated as there are a number of changes that are required to get this library working again. This is because nxapi's f-token generation now requires oauth to get a f-token due to how Nintendo is now encrypting any POST's that generate a credential to talk to a game's API.

Once we're into September a bit, I'll hopefully have time. I work for a college and am doing a load of prep in anticipation for students to return.

[MiguelAngelLV]

Once we're into September a bit, I'll hopefully have time. I work for a college and am doing a load of prep in anticipation for students to return.

-So, you know, your homework this semester is to adapt the nso-api library to use oauth. Any questions?
-Is it really ethical to use students to do a personal project?
-You, outside of my class. Does anyone have any other questions?