zombiesurvival distorts the display of text in the ULX voting menu

[comminux]

Steps to reproduce

1. Download last git version of https://github.com/TeamUlysses/ulib and https://github.com/TeamUlysses/ulx
2. Open vote menu settings in ULX
3. Increase the number of voting options
4. Press "ulx vote" button

Expected behavior

The voting parameters must have a non-zero vertical margin, similar to how it works in other gamemodes.

Actual behavior

The voting parameters are compressed as if there are no margins

Error(s) in server console, if any

None

Error(s) in player's console, if any

None

Version

310793a
ULib v2.70d (05/12/2018)
ULX v3.73d (05/21/2018)
TeamUlysses/ulx@371a4fb

Attached images:

[arthurgeron]

It could mean some font settings are applying to the vote menu, or not, but it looks like a ULX issue rather than a z's issue, have you opened a issue with them?

[comminux]

Yes, I also opened the issue in ULX repo.

TeamUlysses/ulx#197

[JetBoom]

I will revive this with this bit of code

zombiesurvival/gamemodes/zombiesurvival/gamemode/perf/shared/buffthefps.lua

Line 19 in bdf0dac

--local TEXT_ALIGN_TOP = 3

Previously I hard coded this because the bottom and top text aligns kept getting swapped between gmod updates like 3-4 times total. It’s stable now but the values are not what they’re supposed to be and the lines should be removed. ZS however currently is coded to rely on those wrong values so a plethora of other locations would gave to be updated to use the correct text align constant.