From 82078d1777a2f5f07c2af1ffe6174efd7ef6c8fd Mon Sep 17 00:00:00 2001 From: Jonathan Fraine Date: Mon, 22 Jul 2019 14:27:53 +0300 Subject: [PATCH 1/3] Fixed missing kwargs that causes errors Line 1615: "if image is not None:" causes error that says "Image is not defined" because it was not included as a keyword, which the conditional statement implies that it should be. --- pynrc/pynrc_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pynrc/pynrc_core.py b/pynrc/pynrc_core.py index 0136d191..d85ac3f1 100644 --- a/pynrc/pynrc_core.py +++ b/pynrc/pynrc_core.py @@ -1567,7 +1567,7 @@ def bg_zodi(self, zfact=None, **kwargs): return fzodi_pix - def saturation_levels(self, sp, full_size=True, ngroup=2, **kwargs): + def saturation_levels(self, sp, image = None, full_size=True, ngroup=2, **kwargs): """Saturation levels. Create image showing level of saturation for each pixel. From dfca458f09457dfc89646bc392ef5ced81652b95 Mon Sep 17 00:00:00 2001 From: Jonathan Fraine Date: Mon, 22 Jul 2019 14:52:47 +0300 Subject: [PATCH 2/3] plot_hdulist in `nb_funcs` instead of `obs_nircam` The function 'plot_hdulist' was moved to nb_funcs instead of obs_nircam --- notebooks/Coronagraph_Basics.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebooks/Coronagraph_Basics.ipynb b/notebooks/Coronagraph_Basics.ipynb index 5294bdfb..daad1308 100644 --- a/notebooks/Coronagraph_Basics.ipynb +++ b/notebooks/Coronagraph_Basics.ipynb @@ -496,7 +496,7 @@ } ], "source": [ - "from pynrc.obs_nircam import plot_hdulist\n", + "from pynrc.nb_funcs import plot_hdulist\n", "from matplotlib.patches import Circle\n", "\n", "fig, axes = plt.subplots(1,3, figsize=(14,4.3))\n", From 5f928c24f7856557316e05c5ca2b6cb95d7f1655 Mon Sep 17 00:00:00 2001 From: Jonathan Fraine Date: Mon, 22 Jul 2019 15:09:49 +0300 Subject: [PATCH 3/3] plot_* are not in `nb_funcs` instead of `obs_nircam` Changed `from pynrc.obs_nircam import plot_contrasts, plot_planet_patches, plot_contrasts_mjup` to `from pynrc.nb_funcs import plot_contrasts, plot_planet_patches, plot_contrasts_mjup` because the functions have moved. --- notebooks/Coronagraph_Basics.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebooks/Coronagraph_Basics.ipynb b/notebooks/Coronagraph_Basics.ipynb index daad1308..a23633d5 100644 --- a/notebooks/Coronagraph_Basics.ipynb +++ b/notebooks/Coronagraph_Basics.ipynb @@ -594,7 +594,7 @@ } ], "source": [ - "from pynrc.obs_nircam import plot_contrasts, plot_planet_patches, plot_contrasts_mjup\n", + "from pynrc.nb_funcs import plot_contrasts, plot_planet_patches, plot_contrasts_mjup\n", "import matplotlib.patches as mpatches\n", "\n", "# fig, ax = plt.subplots(figsize=(8,5))\n",