-
Notifications
You must be signed in to change notification settings - Fork 7
Description
Describe the bug
A list of code locations where expressions get evaluated more than once.
Expected behavior
Expressions should only ever be evaluated once per get()/execute() call (excepting intentional circumstances like mapping expressions or similar)
Locations
Lusk/src/main/java/it/jakegblp/lusk/elements/anvilgui/conditions/CondAnvilGuiViewing.java
Line 54 in 54b56ef
| AnvilGuiWrapper anvilGuiWrapper = anvilGuiWrapperExpression.getSingle(event); |
Lusk/src/main/java/it/jakegblp/lusk/elements/minecraft/blocks/bell/effects/EffRingBell.java
Line 51 in 54b56ef
| entityExpression != null ? entityExpression.getSingle(event) : null, |
Lusk/src/main/java/it/jakegblp/lusk/elements/minecraft/blocks/block/events/EvtBlockIgnite.java
Line 60 in 54b56ef
| || igniteCauseLiterals.getAll().length == 0 |
Line 49 in 54b56ef
| return test(boundingBox1, event, box1 -> test(boundingBox2, event, box1::overlaps), isNegated()); |
Line 52 in 54b56ef
| test(objects, event, object -> { // todo: utils |
Line 46 in 54b56ef
| return worldExpression.stream(event).flatMap(world -> boundingBoxExpression.stream(event).flatMap(boundingBox -> |
Line 51 in 54b56ef
| return worldExpression.stream(event).flatMap(world -> world.getNearbyEntities(boundingBox, filter).stream()); |
Line 48 in 54b56ef
| && test(equipmentSlotExpression, event, |
Line 74 in 54b56ef
| bodyPartExpression.stream(event) |
Line 109 in 54b56ef
| .flatMap(armorStand -> bodyPartExpression.stream(event) |
Line 62 in 54b56ef
| .flatMap(entity -> equipmentSlotExpression.stream(event) |
Line 83 in 54b56ef
| .forEach(entity -> equipmentSlotExpression.stream(event) |
Lusk/src/main/java/it/jakegblp/lusk/elements/minecraft/entities/fox/conditions/CondFoxTrusts.java
Line 41 in 54b56ef
| return test(offlinePlayerExpression, event, offlinePlayer -> { |
Line 65 in 54b56ef
| rotationExpression.stream(event), |
Line 56 in 54b56ef
| for (EntitySnapshot snapshot : snapshots.getAll(event)) { |
Lusk/src/main/java/it/jakegblp/lusk/elements/minecraft/mixed/expressions/ExprCoordinates.java
Line 74 in 54b56ef
| .flatMap(axis -> getExpr().stream(e) |
Metadata
Metadata
Assignees
Labels
Projects
Status