Skip to content

ExprItemFrameDropChance doesn't handle nan values #69

@sovdeeth

Description

@sovdeeth

Describe the bug
Setting ExprItemFrameDropChance to NaN results in an exception.

To Reproduce
!set item frame item drop chance of target to NaN value

Expected behavior
Nothing

Screenshots
If applicable, add screenshots to help explain your problem.

/sk info:

[01:24:30 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[01:24:30 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[01:24:30 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[01:24:30 INFO]: [Skript] Server Version: 1.21.10-DEV-080a72f (MC: 1.21.10)
[01:24:30 INFO]: [Skript] Skript Version: 2.13.1 (skriptlang-github)
[01:24:30 INFO]: [Skript] Installed Skript Addons:
[01:24:30 INFO]: [Skript]  - skript-reflect v2.6.1 (https://github.com/SkriptLang/skript-reflect)
[01:24:30 INFO]: [Skript]  - Lusk v1.3.11 (https://github.com/JakeGBLP/Lusk)
[01:24:30 INFO]: [Skript]  - SkBee v3.13.3 (https://github.com/ShaneBeee/SkBee)
[01:24:30 INFO]: [Skript]  - oopsk v1.0-beta2 (https://github.com/sovdeeth/oopsk)
[01:24:30 INFO]: [Skript] Installed dependencies: None

Additional context

[02:13:41 ERROR]: #!#! 
[02:13:41 ERROR]: #!#! [Skript] Severe Error:
[02:13:41 ERROR]: #!#! 
[02:13:41 ERROR]: #!#! An unexpected error occurred with Skript. This issue is likely not your fault.
[02:13:41 ERROR]: #!#! You are using some plugins that alter how Skript works (addons).
[02:13:41 ERROR]: #!#! Full list of addons:
[02:13:41 ERROR]: #!#! SkBee v3.13.3 (https://github.com/ShaneBeee/SkBee)
[02:13:41 ERROR]: #!#! skript-reflect v2.6.1 (https://github.com/SkriptLang/skript-reflect)
[02:13:41 ERROR]: #!#! oopsk v1.0-beta2 (https://github.com/sovdeeth/oopsk)
[02:13:41 ERROR]: #!#! Lusk v1.3.11 (https://github.com/JakeGBLP/Lusk)
[02:13:41 ERROR]: #!#! We could not identify related addons, it might also be a Skript issue.
[02:13:41 ERROR]: #!#! Try temporarily removing the listed plugins one by one to identify the cause.
[02:13:41 ERROR]: #!#! If removing a plugin resolves the issue, please report the problem to the plugin developer.
[02:13:41 ERROR]: #!#! 
[02:13:41 ERROR]: #!#! Stack trace:
[02:13:41 ERROR]: #!#! Caused by: java.lang.IllegalArgumentException: Chance (NaN) outside range [0, 1]
[02:13:41 ERROR]: #!#!     at com.google.common.base.Preconditions.checkArgument(Preconditions.java:218)
[02:13:41 ERROR]: #!#!     at org.bukkit.craftbukkit.entity.CraftItemFrame.setItemDropChance(CraftItemFrame.java:77)
[02:13:41 ERROR]: #!#!     at Lusk-1.3.11.jar//it.jakegblp.lusk.elements.minecraft.entities.itemframe.expressions.ExprItemFrameDropChance.set(ExprItemFrameDropChance.java:59)
[02:13:41 ERROR]: #!#!     at Lusk-1.3.11.jar//it.jakegblp.lusk.elements.minecraft.entities.itemframe.expressions.ExprItemFrameDropChance.set(ExprItemFrameDropChance.java:15)
[02:13:41 ERROR]: #!#!     at Lusk-1.3.11.jar//it.jakegblp.lusk.api.skript.Changeable.change(Changeable.java:103)
[02:13:41 ERROR]: #!#!     at Lusk-1.3.11.jar//it.jakegblp.lusk.api.skript.SimplerPropertyExpression.change(SimplerPropertyExpression.java:25)
[02:13:41 ERROR]: #!#!     at Skript-2.13.1.jar//ch.njol.skript.effects.EffChange.execute(EffChange.java:323)
[02:13:41 ERROR]: #!#!     at Skript-2.13.1.jar//ch.njol.skript.lang.Effect.run(Effect.java:42)
[02:13:41 ERROR]: #!#!     at Skript-2.13.1.jar//ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:40)
[02:13:41 ERROR]: #!#!     at Skript-2.13.1.jar//ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:67)
[02:13:41 ERROR]: #!#!     at Skript-2.13.1.jar//ch.njol.skript.command.Commands.handleEffectCommand(Commands.java:191)
[02:13:41 ERROR]: #!#!     at Skript-2.13.1.jar//ch.njol.skript.command.Commands$2.lambda$onPlayerChat$0(Commands.java:290)
[02:13:41 ERROR]: #!#!     at org.bukkit.craftbukkit.scheduler.CraftFuture.run(CraftFuture.java:88)
[02:13:41 ERROR]: #!#!     at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474)
[02:13:41 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1610)
[02:13:41 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1506)
[02:13:41 ERROR]: #!#!     at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:430)
[02:13:41 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1234)
[02:13:41 ERROR]: #!#!     at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:382)
[02:13:41 ERROR]: #!#!     at java.base/java.lang.Thread.run(Thread.java:1583)
[02:13:41 ERROR]: #!#! 
[02:13:41 ERROR]: #!#! Skript: 2.13.1 (latest)
[02:13:41 ERROR]: #!#!     Flavor: skriptlang-github
[02:13:41 ERROR]: #!#!     Date: 20:23:36.669446
[02:13:41 ERROR]: #!#! Bukkit: 1.21.10-R0.1-SNAPSHOT
[02:13:41 ERROR]: #!#! Minecraft: 1.21.10
[02:13:41 ERROR]: #!#! Java: 21.0.3 (Java HotSpot(TM) 64-Bit Server VM 21.0.3+7-LTS-152)
[02:13:41 ERROR]: #!#! OS: Windows 10 amd64 10.0
[02:13:41 ERROR]: #!#! 
[02:13:41 ERROR]: #!#! Server platform: Paper
[02:13:41 ERROR]: #!#! 
[02:13:41 ERROR]: #!#! Current node: null
[02:13:41 ERROR]: #!#! Current item: set item frame item drop chance of target to NaN
[02:13:41 ERROR]: #!#! Thread: Server thread
[02:13:41 ERROR]: #!#! Language: english
[02:13:41 ERROR]: #!#! Link parse mode: DISABLED
[02:13:41 ERROR]: #!#! End of Error.
[02:13:41 ERROR]: #!#!

Metadata

Metadata

Assignees

Labels

Area: Lusk (Skript)Takes place in the 'skript' module. More specifically in the skript implementation.Priority: LowCan wait.Status: PlannedPlanned for implementation. Not waiting on other features or changes to be implemented.Type: BugSomething isn't working

Projects

Status

Accepted

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions