Skip to content

Newline issue #3

@gkoundry

Description

@gkoundry

I tried running buddy on linux over an ssh connection using terminator and each output row was starting from the end of the previous line instead of the left side of the window. I had to apply this change to make it work properly:

diff --git a/ascii_play/renderers.py b/ascii_play/renderers.py
index 2ffa196..4fbf6fb 100644
--- a/ascii_play/renderers.py
+++ b/ascii_play/renderers.py
@@ -45,7 +45,7 @@ def render_half(frame: np.ndarray, cols: int, rows: int,
     bg = _bg(fb[:,0], fb[:,1], fb[:,2]).reshape(rows, cols)
 
     cells = np.char.add(np.char.add(fg.astype(str), bg.astype(str)), UPPER_HALF)
-    return move_home() + "\n".join("".join(row) for row in cells) + reset()
+    return move_home() + "\r\n".join("".join(row) for row in cells) + reset()
 
 
 # ── ASCII density 
@@ -71,7 +71,7 @@ def render_ascii(frame: np.ndarray, cols: int, rows: int,
     fg   = _fg(flat[:,0], flat[:,1], flat[:,2]).reshape(rows, cols)
 
     cells = np.char.add(fg.astype(str), char_grid.astype(str))
-    return move_home() + "\n".join("".join(row) for row in cells) + reset()
+    return move_home() + "\r\n".join("".join(row) for row in cells) + reset()
 
 
 # ── Braille ───────────────────────────────────────────────────────────────────
@@ -118,7 +118,7 @@ def render_braille(frame: np.ndarray, cols: int, rows: int,
     fg     = _fg(flat[:,0], flat[:,1], flat[:,2]).reshape(rows, cols)
 
     cells = np.char.add(fg.astype(str), char_grid.astype(str))
-    return move_home() + "\n".join("".join(row) for row in cells) + reset()
+    return move_home() + "\r\n".join("".join(row) for row in cells) + reset()
 
 
 # ── Registry ──────────────────────────────────────────────────────────────────

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions