make repeating code into function

Author: JSaurusRex

src/game/client/gameclient.cpp

@@ -2417,6 +2417,43 @@ void CGameClient::UpdateEditorIngameMoved()
 	}
 }
 
+void CGameClient::ApplyPredictInputs(int Tick, bool Direct, CGameWorld& GameWorld)
+{
+	for(int i = 0; i < MAX_CLIENTS; i++)
+	{
+		if(CCharacter *pChar = GameWorld.GetCharacterById(i))
+		{
+			if(i == m_aLocalIds[0] || (Client()->DummyConnected() && i == m_aLocalIds[1]))
+				continue;
+
+			const CNetMsg_Sv_PreInput PreInput = m_aClients[i].m_aPreInputs[Tick % 200];
+			if(PreInput.m_IntendedTick != Tick)
+				continue;
+
+			//convert preinput to input
+			CNetObj_PlayerInput Input = {0};
+			Input.m_Direction = PreInput.m_Direction;
+			Input.m_TargetX = PreInput.m_TargetX;
+			Input.m_TargetY = PreInput.m_TargetY;
+			Input.m_Jump = PreInput.m_Jump;
+			Input.m_Fire = PreInput.m_Fire;
+			Input.m_Hook = PreInput.m_Hook;
+			Input.m_WantedWeapon = PreInput.m_WantedWeapon;
+			Input.m_NextWeapon = PreInput.m_NextWeapon;
+			Input.m_PrevWeapon = PreInput.m_PrevWeapon;
+
+			if(Direct)
+			{
+				pChar->OnDirectInput(&Input);
+			}
+			else
+			{
+				pChar->OnPredictedInput(&Input);
+			}
+		}
+	}
+}
+
 void CGameClient::OnPredict()
 {
 	// store the previous values so we can detect prediction errors
@@ -2513,32 +2550,7 @@ void CGameClient::OnPredict()
 
 		if(g_Config.m_ClAntiPingPreInput)
 		{
-			for(int i = 0; i < MAX_CLIENTS; i++)
-			{
-				if(CCharacter *pChar = m_PredictedWorld.GetCharacterById(i))
-				{
-					if(i == m_aLocalIds[0] || (Client()->DummyConnected() && i == m_aLocalIds[1]))
-						continue;
-
-					const CNetMsg_Sv_PreInput PreInput = m_aClients[i].m_aPreInputs[Tick % 200];
-					if(PreInput.m_IntendedTick != Tick)
-						continue;
-
-					//convert preinput to input
-					CNetObj_PlayerInput Input = {0};
-					Input.m_Direction = PreInput.m_Direction;
-					Input.m_TargetX = PreInput.m_TargetX;
-					Input.m_TargetY = PreInput.m_TargetY;
-					Input.m_Jump = PreInput.m_Jump;
-					Input.m_Fire = PreInput.m_Fire;
-					Input.m_Hook = PreInput.m_Hook;
-					Input.m_WantedWeapon = PreInput.m_WantedWeapon;
-					Input.m_NextWeapon = PreInput.m_NextWeapon;
-					Input.m_PrevWeapon = PreInput.m_PrevWeapon;
-
-					pChar->OnDirectInput(&Input);
-				}
-			}
+			ApplyPredictInputs(Tick, true, m_PredictedWorld);
 		}
 
 		m_PredictedWorld.m_GameTick = Tick;
@@ -2549,32 +2561,7 @@ void CGameClient::OnPredict()
 
 		if(g_Config.m_ClAntiPingPreInput)
 		{
-			for(int i = 0; i < MAX_CLIENTS; i++)
-			{
-				if(CCharacter *pChar = m_PredictedWorld.GetCharacterById(i))
-				{
-					if(pDummyChar == pChar || pLocalChar == pChar)
-						continue;
-
-					const CNetMsg_Sv_PreInput PreInput = m_aClients[i].m_aPreInputs[Tick % 200];
-					if(PreInput.m_IntendedTick != Tick)
-						continue;
-
-					//convert preinput to input
-					CNetObj_PlayerInput Input = {0};
-					Input.m_Direction = PreInput.m_Direction;
-					Input.m_TargetX = PreInput.m_TargetX;
-					Input.m_TargetY = PreInput.m_TargetY;
-					Input.m_Jump = PreInput.m_Jump;
-					Input.m_Fire = PreInput.m_Fire;
-					Input.m_Hook = PreInput.m_Hook;
-					Input.m_WantedWeapon = PreInput.m_WantedWeapon;
-					Input.m_NextWeapon = PreInput.m_NextWeapon;
-					Input.m_PrevWeapon = PreInput.m_PrevWeapon;
-
-					pChar->OnPredictedInput(&Input);
-				}
-			}
+			ApplyPredictInputs(Tick, false, m_PredictedWorld);
 		}
 
 		m_PredictedWorld.Tick();
@@ -3438,32 +3425,7 @@ void CGameClient::UpdatePrediction()
 
 			if(g_Config.m_ClAntiPingPreInput)
 			{
-				for(int i = 0; i < MAX_CLIENTS; i++)
-				{
-					if(CCharacter *pChar = m_GameWorld.GetCharacterById(i))
-					{
-						if(i == m_aLocalIds[0] || (Client()->DummyConnected() && i == m_aLocalIds[1]))
-							continue;
-
-						const CNetMsg_Sv_PreInput PreInput = m_aClients[i].m_aPreInputs[Tick % 200];
-						if(PreInput.m_IntendedTick != Tick)
-							continue;
-
-						//convert preinput to input
-						CNetObj_PlayerInput Input = {0};
-						Input.m_Direction = PreInput.m_Direction;
-						Input.m_TargetX = PreInput.m_TargetX;
-						Input.m_TargetY = PreInput.m_TargetY;
-						Input.m_Jump = PreInput.m_Jump;
-						Input.m_Fire = PreInput.m_Fire;
-						Input.m_Hook = PreInput.m_Hook;
-						Input.m_WantedWeapon = PreInput.m_WantedWeapon;
-						Input.m_NextWeapon = PreInput.m_NextWeapon;
-						Input.m_PrevWeapon = PreInput.m_PrevWeapon;
-
-						pChar->OnDirectInput(&Input);
-					}
-				}
+				ApplyPredictInputs(Tick, true, m_GameWorld);
 			}
 
 			m_GameWorld.m_GameTick = Tick;
@@ -3474,32 +3436,7 @@ void CGameClient::UpdatePrediction()
 
 			if(g_Config.m_ClAntiPingPreInput)
 			{
-				for(int i = 0; i < MAX_CLIENTS; i++)
-				{
-					if(CCharacter *pChar = m_GameWorld.GetCharacterById(i))
-					{
-						if(i == m_aLocalIds[0] || (Client()->DummyConnected() && i == m_aLocalIds[1]))
-							continue;
-
-						const CNetMsg_Sv_PreInput PreInput = m_aClients[i].m_aPreInputs[Tick % 200];
-						if(PreInput.m_IntendedTick != Tick)
-							continue;
-
-						//convert preinput to input
-						CNetObj_PlayerInput Input = {0};
-						Input.m_Direction = PreInput.m_Direction;
-						Input.m_TargetX = PreInput.m_TargetX;
-						Input.m_TargetY = PreInput.m_TargetY;
-						Input.m_Jump = PreInput.m_Jump;
-						Input.m_Fire = PreInput.m_Fire;
-						Input.m_Hook = PreInput.m_Hook;
-						Input.m_WantedWeapon = PreInput.m_WantedWeapon;
-						Input.m_NextWeapon = PreInput.m_NextWeapon;
-						Input.m_PrevWeapon = PreInput.m_PrevWeapon;
-
-						pChar->OnPredictedInput(&Input);
-					}
-				}
+				ApplyPredictInputs(Tick, false, m_GameWorld);
 			}
 
 			m_GameWorld.Tick();

src/game/client/gameclient.h

@@ -653,6 +653,8 @@ class CGameClient : public IGameClient
 	void SendKill() const;
 	void SendReadyChange7();
 
+	void ApplyPredictInputs(int Tick, bool Direct, CGameWorld& GameWorld);
+
 	int m_aNextChangeInfo[NUM_DUMMIES];
 
 	// DDRace