Merge pull request #65 from Gaya/hotfix/max-length

Hotfix: max length of VARCHAR based on charset

Author: Gaya

README.txt

@@ -5,7 +5,7 @@ Donate link: https://abtestingforwp.com/
 Requires at least: 5.0
 Tested up to: 5.4
 Requires PHP: 5.6
-Stable tag: 1.18.1
+Stable tag: 1.18.2
 License: GPLv3
 License URI: https://www.gnu.org/licenses/gpl-3.0.html
 
@@ -95,6 +95,9 @@ You can find the [source and repository over at GitHub](https://github.com/Gaya/
 5. Integration with HTML Forms
 
 == Changelog ==
+= 1.18.2 =
+* Added max length for varchar fields in utf8mb4 enabled databases
+
 = 1.18.1 =
 * Added database repair tool
 

ab-testing-for-wp.php

@@ -1,13 +1,13 @@
 <?php
 /**
  * @package ABTestingForWP
- * @version 1.18.1
+ * @version 1.18.2
  */
 /*
     Plugin Name: A/B Testing for WordPress
     Plugin URI: https://abtestingforwp.com
     Description: Easiest way to create split tests on your WordPress sites, right from the content editor!
-    Version: 1.18.1
+    Version: 1.18.2
     Author: CleverNode
     Author URI: https://theclevernode.com
     Text Domain: ab-testing-for-wp

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "ab-test-wordpress",
-  "version": "1.18.1",
+  "version": "1.18.2",
   "description": "A/B Test right from your WordPress posts.",
   "main": "index.js",
   "scripts": {

package.json

@@ -123,7 +123,7 @@ private function fillInTitle($tablePrefix) {
         return "UPDATE `{$tablePrefix}ab_testing_for_wp_ab_test` AS t
         INNER JOIN `{$tablePrefix}posts` AS p on t.postId = p.ID
         SET t.title = CONCAT('Test \"', p.post_title, '\"')
-        WHERE t.name IS NULL";
+        WHERE t.title IS NULL";
     }
 
     private function postGoalToVarchar($tablePrefix) {
@@ -132,11 +132,12 @@ private function postGoalToVarchar($tablePrefix) {
 
     private function addVariantConditions($tablePrefix) {
         $collate = $this->getDBCollate();
+        $maxLength = $this->getMaxVarcharLength();
 
         return "CREATE TABLE IF NOT EXISTS `{$tablePrefix}ab_testing_for_wp_variant_condition` (
             `variantId` varchar(32) NOT NULL DEFAULT '',
-            `key` varchar(255) NOT NULL DEFAULT '',
-            `value` varchar(255) NOT NULL DEFAULT '',
+            `key` varchar({$maxLength}) NOT NULL DEFAULT '',
+            `value` varchar({$maxLength}) NOT NULL DEFAULT '',
             PRIMARY KEY (`variantId`, `key`, `value`)
         ) ENGINE = InnoDB {$collate};";
     }
@@ -158,6 +159,19 @@ private function getDBCollate() {
 		return $collate;
     }
 
+    private function getMaxVarcharLength() {
+        global $wpdb;
+        $collate = '';
+
+        if ($wpdb->has_cap('collation')) {
+            if ($wpdb->charset === 'utf8mb4') {
+                return 191;
+            }
+        }
+
+        return 255;
+    }
+
     private function removeTables() {
         global $wpdb;
 
@@ -183,6 +197,7 @@ private function createTables() {
         $wpdb->show_errors();
 
         $collate = $this->getDBCollate();
+        $maxLength = $this->getMaxVarcharLength();
 
 		$tablePrefix = $wpdb->prefix;
 
@@ -206,7 +221,7 @@ private function createTables() {
 		CREATE TABLE IF NOT EXISTS `{$tablePrefix}ab_testing_for_wp_variant` (
             `id` varchar(32) NOT NULL DEFAULT '',
             `testId` varchar(32) DEFAULT NULL,
-            `name` varchar(255) DEFAULT NULL,
+            `name` varchar({$maxLength}) DEFAULT NULL,
             `participants` int(11) DEFAULT 0,
             `conversions` int(11) DEFAULT 0,
             PRIMARY KEY (`id`)