-
Notifications
You must be signed in to change notification settings - Fork 2
Does not work with CCL #5
Description
Looking at the code, CCL is presumably supported, but it fails to compile:
Read error between positions 2119 and 2671 in /home/sdilts/Programs/mahogany/dependencies/cl-freelock/src/atomics.lisp.
> Error: Reader error: No external symbol named "HARD-MEMORY-BARRIER" in package #<Package "CCL"> .
> While executing: CCL::%PARSE-TOKEN, in process listener(1).
> Type :GO to continue, :POP to abort, :R for a list of available restarts.
> If continued: Create and use the internal symbol CCL::HARD-MEMORY-BARRIER
> Type :? for other options.
1 > :POP
When checking if ccl::hard-memory-barrier is just an internal symbol, it doesn't work as a function:
? (ccl::hard-memory-barrier)
> Error: Undefined function CCL::HARD-MEMORY-BARRIER called with arguments () .
> While executing: CCL::TOPLEVEL-EVAL, in process listener(1).
> Type :GO to continue, :POP to abort, :R for a list of available restarts.
> If continued: Retry applying CCL::HARD-MEMORY-BARRIER to NIL.
> Type :? for other options.
1 >
Digging into more of the code, the behavior of the CAS operation that is being used doesn't match what this project's doc string says it does, so the implementation probably won't work anyways.
I will be taking steps this months to fix all of these issues. I'm right there will you. If you want to collaborate aswell, I would be open to the help for sure.
To start with, I'm going to investigate the CAS function you questioned. You can expect a follow up sometime this week or early next week.
And I will also briefly scan through the docstrings to see if I can spot anything that needs to be reworded.