Skip to content

Commit fd6801b

Browse files
committed
fix: change benchmark tool from 'benchmarkjs' to 'customBiggerIsBetter'
The github-action-benchmark with tool: 'benchmarkjs' expects a different format than what we're providing. The 'benchmarkjs' tool expects output from the actual Benchmark.js library with specific fields. Since we're providing custom JSON with 'name', 'unit', and 'value' fields, we should use 'customBiggerIsBetter' tool instead (higher ops/sec is better). This fixes the error: 'No benchmark result was found in bench-results.json' The customBiggerIsBetter tool accepts our format: [ { "name": "...", "unit": "ops/sec", "value": 1234567 } ]
1 parent 4fc908f commit fd6801b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/benchmark.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
7878
with:
7979
name: om-data-mapper Performance
80-
tool: 'benchmarkjs'
80+
tool: 'customBiggerIsBetter'
8181
output-file-path: bench-results.json
8282
github-token: ${{ secrets.GITHUB_TOKEN }}
8383
auto-push: true

0 commit comments

Comments
 (0)