From 18d83d0923eab0062cab5b30c903fa61eabaebc3 Mon Sep 17 00:00:00 2001 From: sublimnl Date: Sat, 19 Jul 2025 16:54:01 -0400 Subject: [PATCH 1/2] fix: ensure prettier recognizes .ts files due to a bug in prettier 3.6.* / @prettier/plugin-xml --- .../file-templates/static-mod/prettier.config.mjs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs b/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs index 374f204e7..a5c96cb0f 100644 --- a/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs +++ b/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs @@ -20,6 +20,14 @@ const config = { }, }, + // Ensure that TypeScript files are recognized as TypeScript files. + { + files: ["**/*.ts"], + options: { + parser: "typescript", + }, + }, + // Allow proper formatting of XML files: // https://github.com/prettier/plugin-xml#configuration { From c91abf5035ead906600f2b64292c00513ba07454 Mon Sep 17 00:00:00 2001 From: Zamiell <5511220+Zamiell@users.noreply.github.com> Date: Sat, 19 Jul 2025 17:29:08 -0400 Subject: [PATCH 2/2] different fix --- .../file-templates/static-mod/prettier.config.mjs | 12 +++--------- prettier.config.mjs | 4 +++- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs b/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs index a5c96cb0f..d4a6c8a73 100644 --- a/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs +++ b/packages/isaacscript-cli/file-templates/static-mod/prettier.config.mjs @@ -8,7 +8,9 @@ const config = { plugins: [ "prettier-plugin-organize-imports", // Prettier does not format imports by default. "prettier-plugin-packagejson", // Prettier does not format "package.json" by default. - "@prettier/plugin-xml", // Prettier does not format XML files by default. + // TODO: This plugin is bugged with the latest version of Prettier and tries to format + // TypeScript files as XML files. + /// "@prettier/plugin-xml", // Prettier does not format XML files by default. ], overrides: [ @@ -20,14 +22,6 @@ const config = { }, }, - // Ensure that TypeScript files are recognized as TypeScript files. - { - files: ["**/*.ts"], - options: { - parser: "typescript", - }, - }, - // Allow proper formatting of XML files: // https://github.com/prettier/plugin-xml#configuration { diff --git a/prettier.config.mjs b/prettier.config.mjs index 374f204e7..d4a6c8a73 100644 --- a/prettier.config.mjs +++ b/prettier.config.mjs @@ -8,7 +8,9 @@ const config = { plugins: [ "prettier-plugin-organize-imports", // Prettier does not format imports by default. "prettier-plugin-packagejson", // Prettier does not format "package.json" by default. - "@prettier/plugin-xml", // Prettier does not format XML files by default. + // TODO: This plugin is bugged with the latest version of Prettier and tries to format + // TypeScript files as XML files. + /// "@prettier/plugin-xml", // Prettier does not format XML files by default. ], overrides: [