Project III - Javier Rodriguez

[xrodrimo]

https://github.com/xrodrimo/project-III-geospatial-data

[sh-ih]

🗺️ Nice work! Some comments:

• Repository
  Your repository has a good folder structure and your file names are descriptive. Keep working like that and you’ll always have organized repositories.

The src folder is commonly used to store your .py files. You could create a specific folder called notebooks to store your .ipynb files and another one called maps, instead of having both types of files mixed inside src.

I see you added .env to your .gitignore but it still got pushed. If you want to check that, try untracking .env so it gets deleted from your repo, but you keep it on your computer (https://sufiyanyasa.com/blog/git-untrack-file/)

• README
  You need to complete your README. It gets cut off after the second bullet point of the characteristics of the company you were searching for.

Even if your project is totally done, an incomplete README sends the incorrect message that this project is not finished.

Right now, the README doesn’t show which is the location or the coordinates of the location you chose.

• Code
  Your notebooks are clean and organized. I really like how you specify which venue are you working on on the cell before you start with your code and functions.

Before you push your notebooks, make sure you are not printing the complete json, because it gets really long. When you are working, it is ok to see the whole json, but before pushing, you can change it to .sample() so only a small selection appears.

• Maps
  You need to add your analysis and conclusions inside your notebooks. You have the code to create the maps and both NY and SF are well done, but I didn’t find any text telling me which one was the chosen location. I suppose it is NY, because it has more relevant places inside the circles than the SF map, but you need to state that clearly both inside your notebook and in your README