From 5262ea70cc973ce12284649b8eb6245da68164d9 Mon Sep 17 00:00:00 2001 From: Marvin Kruse Date: Sun, 22 Jun 2025 15:08:40 +0200 Subject: [PATCH 1/3] Temp Fix: qacc payout issue --- .../paymentProcessor/PP_Streaming_v1.sol | 26 ++++++++++++++----- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/src/modules/paymentProcessor/PP_Streaming_v1.sol b/src/modules/paymentProcessor/PP_Streaming_v1.sol index 1e091c66b..316b01099 100644 --- a/src/modules/paymentProcessor/PP_Streaming_v1.sol +++ b/src/modules/paymentProcessor/PP_Streaming_v1.sol @@ -540,17 +540,29 @@ contract PP_Streaming_v1 is Module_v1, IPP_Streaming_v1 { uint streamId; for (index; index < streamIdsArrayLength;) { streamId = streamIdsArray[index]; - _claimForSpecificStream(client, paymentReceiver, streamId); + + // ------------------------------------------------------- + // Note: Temporary Fix to prevent claims of faulty streams + // _claimForSpecificStream(client, paymentReceiver, streamId); + // ------------------------------------------------------- // If the paymentOrder being removed was already past its duration, then it would have been removed // in the earlier _claimForSpecificStream call. // Otherwise, we would remove that paymentOrder in the following lines. - if ( - block.timestamp - < endForSpecificStream(client, paymentReceiver, streamId) - ) { - _afterClaimCleanup(client, paymentReceiver, streamId); - } + // ------------------------------------------------------- + // Note: Temporary Fix to prevent claims of faulty streams + // if ( + // block.timestamp + // < endForSpecificStream(client, paymentReceiver, streamId) + // ) { + // _afterClaimCleanup(client, paymentReceiver, streamId); + // } + // ------------------------------------------------------- + + // Note: Temporary Fix to cancel all of the faulty streams + // ------------------------------------------------------- + _afterClaimCleanup(client, paymentReceiver, streamId); + // ------------------------------------------------------- unchecked { ++index; From e152a55147fc158c6655e3179e441b8f291aca30 Mon Sep 17 00:00:00 2001 From: Marvin Kruse Date: Sun, 22 Jun 2025 15:33:37 +0200 Subject: [PATCH 2/3] Temp Fix: Allow admin to run cancelRunningOrders --- src/modules/paymentProcessor/PP_Streaming_v1.sol | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/modules/paymentProcessor/PP_Streaming_v1.sol b/src/modules/paymentProcessor/PP_Streaming_v1.sol index 316b01099..a7b01f3d8 100644 --- a/src/modules/paymentProcessor/PP_Streaming_v1.sol +++ b/src/modules/paymentProcessor/PP_Streaming_v1.sol @@ -245,8 +245,9 @@ contract PP_Streaming_v1 is Module_v1, IPP_Streaming_v1 { /// @inheritdoc IPaymentProcessor_v1 function cancelRunningPayments(IERC20PaymentClientBase_v1 client) external - onlyModule - validClient(address(client)) + // onlyModule + // validClient(address(client)) + onlyOrchestratorAdmin { _cancelRunningOrders(address(client)); } From 63dbbd2186d6f558e984765eee3cf5c4220093c2 Mon Sep 17 00:00:00 2001 From: Marvin Kruse Date: Sun, 22 Jun 2025 16:04:21 +0200 Subject: [PATCH 3/3] Fix: Formatting --- src/modules/paymentProcessor/PP_Streaming_v1.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/paymentProcessor/PP_Streaming_v1.sol b/src/modules/paymentProcessor/PP_Streaming_v1.sol index a7b01f3d8..e14f297cf 100644 --- a/src/modules/paymentProcessor/PP_Streaming_v1.sol +++ b/src/modules/paymentProcessor/PP_Streaming_v1.sol @@ -247,7 +247,7 @@ contract PP_Streaming_v1 is Module_v1, IPP_Streaming_v1 { external // onlyModule // validClient(address(client)) - onlyOrchestratorAdmin + onlyOrchestratorAdmin { _cancelRunningOrders(address(client)); } @@ -541,7 +541,7 @@ contract PP_Streaming_v1 is Module_v1, IPP_Streaming_v1 { uint streamId; for (index; index < streamIdsArrayLength;) { streamId = streamIdsArray[index]; - + // ------------------------------------------------------- // Note: Temporary Fix to prevent claims of faulty streams // _claimForSpecificStream(client, paymentReceiver, streamId);