Problem#3

[artman325]

Average price are not available from beginning of deploy.
we using oracle like in Openzeppelin SimpleOracle (contract acummulate price the only once in period(24h) and calculate average price by formula
averagePrice = (cumulativePriceLast - cumulativePrevious)/windowSize;
and cumulativePrice = (reserve1/reserve2)*timeElapsed;

case#1:

-contract deployed
-adding initial liquidity
-make update() 
cumulativeLast changes,but average price seems is not correct, because time_passed = 0;cumulativePrevious equal 0
cumulativePriceLast = 100*100/0
averagePrice = (0-0)/86400 = 0

seems happens smth unexpected

case#2:

-contract deployed
-adding initial liquidity
-make forceSync for uniswapPair contract
- pass several seconds(50 sec) and make update() 
cumulativeLast changes,but average price seems is not correct, because time_passed = too low like several seconds i.e. 50; cumulativePrevious equal 0;
cumulativePriceLast = 100*100/50
averagePrice = (200-0)/86400

seems averagePrice are wrong

case#3:

-contract deployed
-adding initial liquidity
-make forceSync for uniswapPair contract
- Users do couple of swaps But admin didn't call update(), so price will be freeze

And seems we can not do it in user transactin swap, because price will changed and can't do atomic swap

Summary:
Please provide an exmaple workflow how contract will work using average price in calculation

[EGreg]

Solution: make a special case calculation for the first day. The average price will be equal to the initial price from parameters. The next day, everything should be fine, as a new bucket will begin. When I say day, I mean bucket interval but by default that interval = DAY. So, the first day, no owner will be able to mint and no one will be able to mint and addLiquidity, only buy.

On Tue, Aug 2, 2022 at 7:18 AM artman325 ***@***.***> wrote: Average price are not available from beginning of deploy. we using oracle like in Openzeppelin SimpleOracle (contract acummulate price the only once in period(24h) and calculate average price by formula averagePrice = (cumulativePriceLast - cumulativePrevious)/windowSize; and cumulativePrice = (reserve1/reserve2)*timeElapsed; *case#1:* -contract deployed -adding initial liquidity -make update() cumulativeLast changes,but average price seems is not correct, because time_passed = 0;cumulativePrevious equal 0 cumulativePriceLast = 100*100/0 averagePrice = (0-0)/86400 = 0 seems happens smth unexpected *case#2:* -contract deployed -adding initial liquidity -make forceSync for uniswapPair contract - pass several seconds(50 sec) and make update() cumulativeLast changes,but average price seems is not correct, because time_passed = too low like several seconds i.e. 50; cumulativePrevious equal 0; cumulativePriceLast = 100*100/50 averagePrice = (200-0)/86400 seems averagePrice are wrong *case#3:* -contract deployed -adding initial liquidity -make forceSync for uniswapPair contract - Users do couple of swaps But admin didn't call update(), so price will be freeze And seems we can not do it in user transactin swap, because price will changed and can't do atomic swap *Summary:* Please provide an exmaple workflow how contract will work using average price in calculation — Reply to this email directly, view it on GitHub <#6>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACV7P5OWVGJECQPR4KHPBLVXD7W3ANCNFSM55KYL5TQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Sincerely, Greg Magarshak Qbix Inc. (To set up a meeting: https://calendly.com/qbix/meeting)

[EGreg]

Another solution is to have the special case be as follows: during the first day, we use currentPrice instead of averagePrice

On Tue, Aug 2, 2022 at 8:30 AM Gregory Magarshak ***@***.***> wrote: Solution: make a special case calculation for the first day. The average price will be equal to the initial price from parameters. The next day, everything should be fine, as a new bucket will begin. When I say day, I mean bucket interval but by default that interval = DAY. So, the first day, no owner will be able to mint and no one will be able to mint and addLiquidity, only buy. On Tue, Aug 2, 2022 at 7:18 AM artman325 ***@***.***> wrote: > Average price are not available from beginning of deploy. > we using oracle like in Openzeppelin SimpleOracle (contract acummulate > price the only once in period(24h) and calculate average price by formula > averagePrice = (cumulativePriceLast - cumulativePrevious)/windowSize; > and cumulativePrice = (reserve1/reserve2)*timeElapsed; > > *case#1:* > > -contract deployed > -adding initial liquidity > -make update() > cumulativeLast changes,but average price seems is not correct, because time_passed = 0;cumulativePrevious equal 0 > cumulativePriceLast = 100*100/0 > averagePrice = (0-0)/86400 = 0 > > seems happens smth unexpected > > *case#2:* > > -contract deployed > -adding initial liquidity > -make forceSync for uniswapPair contract > - pass several seconds(50 sec) and make update() > cumulativeLast changes,but average price seems is not correct, because time_passed = too low like several seconds i.e. 50; cumulativePrevious equal 0; > cumulativePriceLast = 100*100/50 > averagePrice = (200-0)/86400 > > seems averagePrice are wrong > > *case#3:* > > -contract deployed > -adding initial liquidity > -make forceSync for uniswapPair contract > - Users do couple of swaps But admin didn't call update(), so price will be freeze > > And seems we can not do it in user transactin swap, because price will > changed and can't do atomic swap > > *Summary:* > Please provide an exmaple workflow how contract will work using average > price in calculation > > — > Reply to this email directly, view it on GitHub > <#6>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACV7P5OWVGJECQPR4KHPBLVXD7W3ANCNFSM55KYL5TQ> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- Sincerely, Greg Magarshak Qbix Inc. (To set up a meeting: https://calendly.com/qbix/meeting)

-- Sincerely, Greg Magarshak Qbix Inc. (To set up a meeting: https://calendly.com/qbix/meeting)

[EGreg]

Please change the minimum time interval for updating average price (from cumulative) From a fixed constant like 24 hours To be (blockTimestamp - initialTimestamp) * averagePriceWindow / FRACTION

On Tue, Aug 2, 2022 at 9:40 AM Gregory Magarshak ***@***.***> wrote: Another solution is to have the special case be as follows: during the first day, we use currentPrice instead of averagePrice On Tue, Aug 2, 2022 at 8:30 AM Gregory Magarshak ***@***.***> wrote: > Solution: make a special case calculation for the first day. The average > price will be equal to the initial price from parameters. > > The next day, everything should be fine, as a new bucket will begin. > > When I say day, I mean bucket interval but by default that interval = DAY. > > So, the first day, no owner will be able to mint and no one will be able > to mint and addLiquidity, only buy. > > On Tue, Aug 2, 2022 at 7:18 AM artman325 ***@***.***> > wrote: > >> Average price are not available from beginning of deploy. >> we using oracle like in Openzeppelin SimpleOracle (contract acummulate >> price the only once in period(24h) and calculate average price by formula >> averagePrice = (cumulativePriceLast - cumulativePrevious)/windowSize; >> and cumulativePrice = (reserve1/reserve2)*timeElapsed; >> >> *case#1:* >> >> -contract deployed >> -adding initial liquidity >> -make update() >> cumulativeLast changes,but average price seems is not correct, because time_passed = 0;cumulativePrevious equal 0 >> cumulativePriceLast = 100*100/0 >> averagePrice = (0-0)/86400 = 0 >> >> seems happens smth unexpected >> >> *case#2:* >> >> -contract deployed >> -adding initial liquidity >> -make forceSync for uniswapPair contract >> - pass several seconds(50 sec) and make update() >> cumulativeLast changes,but average price seems is not correct, because time_passed = too low like several seconds i.e. 50; cumulativePrevious equal 0; >> cumulativePriceLast = 100*100/50 >> averagePrice = (200-0)/86400 >> >> seems averagePrice are wrong >> >> *case#3:* >> >> -contract deployed >> -adding initial liquidity >> -make forceSync for uniswapPair contract >> - Users do couple of swaps But admin didn't call update(), so price will be freeze >> >> And seems we can not do it in user transactin swap, because price will >> changed and can't do atomic swap >> >> *Summary:* >> Please provide an exmaple workflow how contract will work using average >> price in calculation >> >> — >> Reply to this email directly, view it on GitHub >> <#6>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AACV7P5OWVGJECQPR4KHPBLVXD7W3ANCNFSM55KYL5TQ> >> . >> You are receiving this because you are subscribed to this thread.Message >> ID: ***@***.***> >> > -- > Sincerely, > Greg Magarshak > Qbix Inc. > > (To set up a meeting: https://calendly.com/qbix/meeting) > -- Sincerely, Greg Magarshak Qbix Inc. (To set up a meeting: https://calendly.com/qbix/meeting)

-- Sincerely, Greg Magarshak Qbix Inc. (To set up a meeting: https://calendly.com/qbix/meeting)

[artman325]

(blockTimestamp - initialTimestamp) * averagePriceWindow / FRACTION

if windowSize will be (blockTimestamp - initialTimestamp) * averagePriceWindow / FRACTION
and timeElapsed = blockTimestamp - lastTimestampWhenPriceUpdated
condition (timeElapsed >= windowSize) will never do (except the only one time in the beginning).

Also what's variable averagePriceWindow ?

[artman325]

even if

averagePriceWindow = 90000
FRACTION = 100000

as you described in slack
we will obtain average price only 6-8 times.
see ruby code and output

iterationsDuration = 365**24*60*60
iterationsStep=10*60
initialTimestamp = Time.now.to_i
blockTimestamp = initialTimestamp
pairObservation_timestampLast = blockTimestamp
averagePriceWindow = 90000 #24*60*60
fraction = 100000 #averagePriceWindow * 1.1
puts "start script at   "+blockTimestamp.to_s
while (blockTimestamp < (initialTimestamp+iterationsDuration))

    timeElapsed = blockTimestamp - pairObservation_timestampLast
    windowSize = (blockTimestamp - initialTimestamp) * averagePriceWindow / fraction
    
    if (timeElapsed >= windowSize) 
        puts "updated at blockTimestamp = "+blockTimestamp.to_s
        pairObservation_timestampLast = blockTimestamp
    end
    
    blockTimestamp = blockTimestamp + iterationsStep
end
puts "stopped script at "+blockTimestamp.to_s

g:\wamp64\www>ruby t.rb
start script at   1659518524
updated at blockTimestamp = 1659518524
updated at blockTimestamp = 1659519124
updated at blockTimestamp = 1659524524
updated at blockTimestamp = 1659578524
updated at blockTimestamp = 1660118524
updated at blockTimestamp = 1665518524 # <-- GMT: Tuesday, 11 October 2022 г., 20:02:04
updated at blockTimestamp = 1719518524
updated at blockTimestamp = 2259518524
updated at blockTimestamp = 7659518524
t.rb:20:in `<main>': Interrupt