make traverseBlocks use proper floor instead of force cast, use MutableBlockPos to prevent unnecessary allocation

Author: zyxkad

src/main/java/de/srendi/advancedperipherals/common/addons/computercraft/peripheral/GeoScannerPeripheral.java

@@ -39,9 +39,9 @@
 
 public class GeoScannerPeripheral extends BasePeripheral<IPeripheralOwner> {
 
-    /*
-    Highly inspired by https://github.com/SquidDev-CC/plethora/ BlockScanner
-    */
+    /**
+     * Highly inspired by https://github.com/SquidDev-CC/plethora/ BlockScanner
+     */
 
     public static final String PERIPHERAL_TYPE = "geo_scanner";
 
@@ -64,7 +64,7 @@ public GeoScannerPeripheral(IPocketAccess pocket, IPocketUpgrade upgrade) {
 
     private static List<Map<String, Object>> scan(List<Map<String, Object>> result, Level level, Vec3 center, int radius) {
         ScanUtils.relativeTraverseBlocks(level, center, radius, (state, pos) -> {
-            HashMap<String, Object> data = new HashMap<>(6);
+            HashMap<String, Object> data = new HashMap<>(6); // 5 normal fields + 1 "notOnShip" flag
             data.put("x", pos.x);
             data.put("y", pos.y);
             data.put("z", pos.z);

src/main/java/de/srendi/advancedperipherals/common/util/ScanUtils.java

@@ -1,6 +1,7 @@
 package de.srendi.advancedperipherals.common.util;
 
 import net.minecraft.core.BlockPos;
+import net.minecraft.util.Mth;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.phys.Vec3;
@@ -18,18 +19,23 @@ public static void traverseBlocks(Level world, Vec3 center, double radius, BiCon
 
     public static void traverseBlocks(Level world, Vec3 center, double radius, BiConsumer<BlockState, Vec3> consumer, boolean relativePosition) {
         final double x = center.x, y = center.y, z = center.z;
-        for (int oX = (int) (x - radius); oX <= (int) (x + radius); oX++) {
-            for (int oY = (int) (y - radius); oY <= (int) (y + radius); oY++) {
-                for (int oZ = (int) (z - radius); oZ <= (int) (z + radius); oZ++) {
-                    BlockPos subPos = new BlockPos(oX, oY, oZ);
-                    BlockState blockState = world.getBlockState(subPos);
-                    if (!blockState.isAir()) {
-                        if (relativePosition) {
-                            consumer.accept(blockState, new Vec3(oX + 0.5 - center.x, oY + 0.5 - center.y, oZ + 0.5 - center.z));
-                        } else {
-                            consumer.accept(blockState, new Vec3(oX, oY, oZ));
-                        }
+        final int minX = Mth.floor(x - radius), maxX = Mth.floor(x + radius);
+        final int minY = Mth.floor(y - radius), maxY = Mth.floor(y + radius);
+        final int minZ = Mth.floor(z - radius), maxZ = Mth.floor(z + radius);
+        final BlockPos.MutableBlockPos subPos = new BlockPos.MutableBlockPos();
+        for (int oX = minX; oX <= maxX; oX++) {
+            for (int oY = minY; oY <= maxY; oY++) {
+                for (int oZ = minZ; oZ <= maxZ; oZ++) {
+                    BlockState blockState = world.getBlockState(subPos.set(oX, oY, oZ));
+                    if (blockState.isAir()) {
+                        continue;
                     }
+                    consumer.accept(
+                        blockState,
+                        relativePosition
+                            ? new Vec3(oX + 0.5 - x, oY + 0.5 - y, oZ + 0.5 - z)
+                            : new Vec3(oX, oY, oZ)
+                    );
                 }
             }
         }