From 553bc59f9a2166f27ce7361fdd5267c973bd02b3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 13:08:16 +0000 Subject: [PATCH 1/2] Initial plan From 9fcdee9047011d109a877df6df071496239679e2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 13:11:29 +0000 Subject: [PATCH 2/2] test: remove hardcoded line number references from SetupTest comments Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com> --- tests/lib/SetupTest.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/lib/SetupTest.php b/tests/lib/SetupTest.php index 6c2f85841b15e..07d3f59d30c6c 100644 --- a/tests/lib/SetupTest.php +++ b/tests/lib/SetupTest.php @@ -190,9 +190,9 @@ public function testSetupHasEventDispatcher(): void { /** * Helper method to extract event parameters from install options - * This mirrors the logic in Setup::install() at line 329 for dataDir and lines 502-503 for admin parameters + * This mirrors the logic in Setup::install() for extracting dataDir and admin parameters * - * Note: This assumes 'directory' key is present in options. Setup::install() has a fallback at lines 321-323 + * Note: This assumes 'directory' key is present in options. Setup::install() has a fallback * that sets a default directory if empty, but our tests always provide this key. */ private function extractInstallationEventParameters(array $options): array { @@ -208,8 +208,7 @@ private function extractInstallationEventParameters(array $options): array { * Test that InstallationCompletedEvent can be created with parameters from install options * * This test verifies that the InstallationCompletedEvent can be properly constructed with - * the parameters that Setup::install() extracts from the options array (see Setup.php line 329 - * for dataDir and lines 502-503 for admin parameters). + * the parameters that Setup::install() extracts from the options array for dataDir and admin parameters. * * Note: Testing that Setup::install() actually dispatches this event requires a full integration * test with database setup, file system operations, and app installation, which is beyond the @@ -226,7 +225,7 @@ public function testInstallationCompletedEventParametersFromInstallOptions(): vo // Extract parameters the same way Setup::install() does [$dataDir, $adminUsername, $adminEmail] = $this->extractInstallationEventParameters($options); - // Create the event as Setup::install() does at lines 504-506 + // Create the event as Setup::install() does after successful installation $event = new InstallationCompletedEvent($dataDir, $adminUsername, $adminEmail); // Verify the event contains the expected values