-
Notifications
You must be signed in to change notification settings - Fork 35
Onboarding project: Celeste #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CelesteNaude
wants to merge
19
commits into
IMQS:master
Choose a base branch
from
CelesteNaude:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
420805c
finished Getting Started settings
CelesteNaude d5ce530
added table & pagination
CelesteNaude b398c11
'search' & 'display n amount of records' function
CelesteNaude 0fada86
edited user interface
CelesteNaude b128b19
enhance performance (number records to fetch)
CelesteNaude 06905e5
attempt #1 global variables
CelesteNaude b4d2b64
add/delete rows when resizing window
CelesteNaude dce5567
fixed table responsiveness errors
CelesteNaude 3e48f44
added debounce and different pagination
CelesteNaude b0bd9c0
fixed add records
CelesteNaude 2fdaee1
Fixed global variables and repetitive code
CelesteNaude 2feb35f
Improved search function
CelesteNaude 9773ed6
Improved pagination buttons' click events
CelesteNaude 5cae654
Moved global variables into seperate class
CelesteNaude a8fa4ff
Logic fixes + code cleanup
CelesteNaude b3c8dba
Added seperate file for doc element variables
CelesteNaude 3eb7c41
Fixed add rows function again
CelesteNaude be96066
Class restructure
CelesteNaude d6e7e06
Added methods in state.ts for event listeners
CelesteNaude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| window.onload = async () => { | ||
| let state = new State(); | ||
|
|
||
| // Get data from server and load into table | ||
| await state.getData().then(resp => { | ||
| if (resp == true) { | ||
| state.loadIntoTable(true); | ||
| } | ||
| }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing |
||
|
|
||
FritzOnFire marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Set needed navigation controls | ||
| state.setSearchButton(); | ||
| state.setPageButtons(); | ||
| state.setResizeEvent(); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "name": "onboard-javascript", | ||
| "version": "1.0.0", | ||
| "description": "onboard", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "build": "tsc --build" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/CelesteNaude/onboard-javascript.git" | ||
| }, | ||
| "author": "celeste", | ||
| "license": "ISC", | ||
| "bugs": { | ||
| "url": "https://github.com/CelesteNaude/onboard-javascript/issues" | ||
| }, | ||
| "homepage": "https://github.com/CelesteNaude/onboard-javascript#readme", | ||
| "dependencies": { | ||
| "@types/jquery.browser": "^0.1.1" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.