From b7e6b15c2e3f239b0dc7745ac2e09e522ec4fde0 Mon Sep 17 00:00:00 2001
From: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Date: Sat, 16 Dec 2023 06:12:13 +0000
Subject: [PATCH] vuln-fix: Use HTTPS instead of HTTP to resolve deps
 CVE-2021-26291

This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Weakness: CWE-829: Inclusion of Functionality from Untrusted Control Sphere
Severity: High
CVSS: 8.1
Detection: CodeQL & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/) & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8


Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/IfHkrYfxx?organizationId=QWxsIEdpdEh1Yg%3D%3D

Co-authored-by: Moderne <team@moderne.io>
---
 atomfeed-client-spring/pom.xml | 8 ++++----
 atomfeed-server/pom.xml        | 2 +-
 atomfeed-spring-server/pom.xml | 8 ++++----
 pom.xml                        | 8 ++++----
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/atomfeed-client-spring/pom.xml b/atomfeed-client-spring/pom.xml
index 38f8acc..dc9d197 100644
--- a/atomfeed-client-spring/pom.xml
+++ b/atomfeed-client-spring/pom.xml
@@ -21,12 +21,12 @@
         <repository>
             <id>spring-maven-release</id>
             <name>Spring Maven Release Repository</name>
-            <url>http://maven.springframework.org/release</url>
+            <url>https://maven.springframework.org/release</url>
         </repository>
         <repository>
             <id>spring-maven-milestone</id>
             <name>Spring Maven Milestone Repository</name>
-            <url>http://maven.springframework.org/milestone</url>
+            <url>https://maven.springframework.org/milestone</url>
         </repository>
     </repositories>
 
@@ -34,12 +34,12 @@
         <pluginRepository>
             <id>spring-maven-release</id>
             <name>Spring Maven Release Repository</name>
-            <url>http://maven.springframework.org/release</url>
+            <url>https://maven.springframework.org/release</url>
         </pluginRepository>
         <pluginRepository>
             <id>spring-maven-milestone</id>
             <name>Spring Maven Milestone Repository</name>
-            <url>http://maven.springframework.org/milestone</url>
+            <url>https://maven.springframework.org/milestone</url>
         </pluginRepository>
     </pluginRepositories>
 
diff --git a/atomfeed-server/pom.xml b/atomfeed-server/pom.xml
index f3bb9ec..042ccff 100644
--- a/atomfeed-server/pom.xml
+++ b/atomfeed-server/pom.xml
@@ -28,7 +28,7 @@
         <repository>
             <id>javax.transaction</id>
             <name>Repository for javax transaction API</name>
-            <url>http://mvnrepository.com/artifact/javax.transaction/jta/1.1</url>
+            <url>https://mvnrepository.com/artifact/javax.transaction/jta/1.1</url>
         </repository>
     </repositories>
 
diff --git a/atomfeed-spring-server/pom.xml b/atomfeed-spring-server/pom.xml
index 1a775c8..71ae046 100644
--- a/atomfeed-spring-server/pom.xml
+++ b/atomfeed-spring-server/pom.xml
@@ -22,12 +22,12 @@
         <repository>
             <id>spring-maven-release</id>
             <name>Spring Maven Release Repository</name>
-            <url>http://maven.springframework.org/release</url>
+            <url>https://maven.springframework.org/release</url>
         </repository>
         <repository>
             <id>spring-maven-milestone</id>
             <name>Spring Maven Milestone Repository</name>
-            <url>http://maven.springframework.org/milestone</url>
+            <url>https://maven.springframework.org/milestone</url>
         </repository>
     </repositories>
 
@@ -35,12 +35,12 @@
         <pluginRepository>
             <id>spring-maven-release</id>
             <name>Spring Maven Release Repository</name>
-            <url>http://maven.springframework.org/release</url>
+            <url>https://maven.springframework.org/release</url>
         </pluginRepository>
         <pluginRepository>
             <id>spring-maven-milestone</id>
             <name>Spring Maven Milestone Repository</name>
-            <url>http://maven.springframework.org/milestone</url>
+            <url>https://maven.springframework.org/milestone</url>
         </pluginRepository>
     </pluginRepositories>
 
diff --git a/pom.xml b/pom.xml
index e066878..1005f15 100644
--- a/pom.xml
+++ b/pom.xml
@@ -214,23 +214,23 @@
         <repository>
             <id>javax.transaction</id>
             <name>Repository for javax transaction API</name>
-            <url>http://mvnrepository.com/artifact/javax.transaction/jta/1.1</url>
+            <url>https://mvnrepository.com/artifact/javax.transaction/jta/1.1</url>
         </repository>
         <repository>
             <id>maven2-repository.dev.java.net</id>
             <name>Java.net Repository for Maven</name>
-            <url>http://download.java.net/maven/2/</url>
+            <url>https://download.java.net/maven/2/</url>
             <layout>default</layout>
         </repository>
         <repository>
             <id>com.springsource.repository.bundles.release</id>
             <name>SpringSource Enterprise Bundle Repository - SpringSource Bundle Releases</name>
-            <url>http://repository.springsource.com/maven/bundles/release</url>
+            <url>https://repository.springsource.com/maven/bundles/release</url>
         </repository>
         <repository>
             <id>com.springsource.repository.bundles.external</id>
             <name>SpringSource Enterprise Bundle Repository - External Bundle Releases</name>
-            <url>http://repository.springsource.com/maven/bundles/external</url>
+            <url>https://repository.springsource.com/maven/bundles/external</url>
         </repository>
     </repositories>