Fetch_lotek_positions returns error when not using start and end dates

[coltonp2022]

Hi,

I have been running into this issue for a while, but I have worked around it just fine; however, for some reason today my work around is not working and is returning a dataframe with 0 rows for some reason. The error I am getting is regarding the dplyr::if_else function.

Error in dplyr::if_else():
! false must be a vector, not NULL.

I think that dplyr must have changed the way their if_else handles null values. I have manually changed the function in my global environment to use NAs instead of NULL values and that seems to have solved the issue. Hope this can be implemented in the future to streamline fetching all the data available on the Lotek web service.

[Huh]

@coltonp2022 thank you for letting me know. We will get on this sometime this week and get back to you.

[ericnewkirk]

This sounds really familiar, I believe there should be a fix somewhere in this mess: #88

[Huh]

@coltonp2022 I updated the code and removed all if_else calls in the lotek code. You can install this test version of the package by the following the instructions below. If you have a minute to test this change and report back I will move the fix from develop to main. I currently do not have any lotek accounts to test with.

SpeedGoat Installation

install.packages("collar", repos = "https://nexus.spdgt.com/repository/spdgt-public/")

User's can add that repo to their .Rprofile to make it available in the future using usethis::edit_r_profile(). And then adding the following line to the file:

options(
  repos = c(
    CRAN = "https://cloud.r-project.org", # Just an example, up to the user
    spdgt = "https://nexus.spdgt.com/repository/spdgt-public/"
  )
)

FWIW, I used %||% operator instead of if_else. This checks for null and if null then does whatever is on the right side.

Thanks

[coltonp2022]

Awesome, thank you for the help! This makes a lot of my code run a lot smoother when needing to get all data available.

[coltonp2022]

The fix worked perfectly and did not give me any errors when not giving start or end dates.

[Huh]

Great, much appreciated. I will merge the PR then so others will have the same version. I am going to close, but if feel free to open if the issue pops up again.