From fa7886b8246ba9bf14c82e96211c70cb731bf5c3 Mon Sep 17 00:00:00 2001 From: stanley gunawan Date: Wed, 4 Apr 2018 17:26:27 +0800 Subject: [PATCH 1/4] Add autoComplete option for the AutoComplete component Textfield --- src/AutoComplete/AutoComplete.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/AutoComplete/AutoComplete.js b/src/AutoComplete/AutoComplete.js index eaeffa2..d646992 100644 --- a/src/AutoComplete/AutoComplete.js +++ b/src/AutoComplete/AutoComplete.js @@ -13,6 +13,7 @@ export default class AutoComplete extends Component { static propTypes = { align: PropTypes.string, + autoComplete: PropTypes.string, className: PropTypes.string, dataIndex: PropTypes.string.isRequired, disabled: PropTypes.bool, @@ -76,7 +77,7 @@ export default class AutoComplete extends Component { render() { const { - align, className, dataIndex, disabled, error, floatingLabel, + align, autoComplete, className, dataIndex, disabled, error, floatingLabel, items, label, offset, readOnly, value, valueIndex, } = this.props const { focused, value: stateValue } = this.state From dd222fdb49e404bb4c3ddd222324831931a20e24 Mon Sep 17 00:00:00 2001 From: stanley gunawan Date: Fri, 6 Apr 2018 10:43:47 +0800 Subject: [PATCH 2/4] Pass autoComplete attribute to Textfield component --- src/AutoComplete/AutoComplete.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/AutoComplete/AutoComplete.js b/src/AutoComplete/AutoComplete.js index d646992..09be389 100644 --- a/src/AutoComplete/AutoComplete.js +++ b/src/AutoComplete/AutoComplete.js @@ -112,6 +112,7 @@ export default class AutoComplete extends Component { floatingLabel, label, readOnly: disabled, + autoComplete, ref: ref => this.input = ref, type: 'text', onChange: this.onTextfieldChange, From 554ad9e4eeac3b86073ec454fa05fccd914bd54a Mon Sep 17 00:00:00 2001 From: stanley gunawan Date: Fri, 6 Apr 2018 13:50:55 +0800 Subject: [PATCH 3/4] Edit autocomplete example to show autoComplete=off --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 3358868..d6f5f34 100644 --- a/README.md +++ b/README.md @@ -92,6 +92,7 @@ const items = [ From 7f09478245ebcd7fabef243689daa90bc8aa088b Mon Sep 17 00:00:00 2001 From: stanley gunawan Date: Fri, 6 Apr 2018 13:59:51 +0800 Subject: [PATCH 4/4] Update autocomplete story with example --- stories/AutoComplete.story.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/stories/AutoComplete.story.js b/stories/AutoComplete.story.js index 80d0c9f..4d92a8d 100644 --- a/stories/AutoComplete.story.js +++ b/stories/AutoComplete.story.js @@ -85,6 +85,25 @@ storiesOf('AutoComplete', module) disabled /> )) + .add('autocomplete off', () => ( +
+ Turn off browser autofill + + Browser default behaviour + +
+ )) .add('lots of values', () => (