Skip to content

Extension manifest missing youtube embed #829

@TheLQ

Description

@TheLQ

Like button does nothing on Edge/Chrome. In Firefox it at least says "Successfully liked" or "Failed to like" (which is a separate issue)

Underlying Issue I think: Injected contentScript missing from the manifest for youtube.com/embed

  1. Download from store node ../node_modules/chrome-extension-fetch/index.js https://chromewebstore.google.com/detail/holodex-plus/mjcecbpccklceljomllkhilglcdcncbh and unzip
  2. Missing from holodex-plus/manifest.json

Meanwhile in Firefox:

  1. Download from store https://addons.mozilla.org/firefox/downloads/file/4281538/holodex_plus-0.5.xpi
  2. Contains expected { "matches": [ "*://*.youtube.com/embed/*" ], "js": [ "content/yt-player.js" ],

The other tell is player's iframe <head> for is missing the injected <script> tag. Even in Chrome the chat gets a chrome-extension://mjcecbpccklceljomllkhilglcdcncbh/assets/yt-chat-inject.ts-CH4o2D1K.js element but not the player.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions