Forward output to MQTT

[rediculum]

Hello
I am not so familiar with JS. Can someone help me in order to combine these two code snippets so they work?

client.on('ready', async () => {
  const vehicle = client.getVehicle(bluelink_config.vin);
  try {
    const response = await vehicle.status();
    //console.log(response);
  } catch (err) {
    // log the error from the command invocation
  }
});

client.on('error', async (err) => {
  // something went wrong with login
});

mqtt_client.on('connect', function() {
  mqtt_client.subscribe('kia/status', function (err) {
    if (!err) {
      mqtt_client.publish('kia/status', response)
    }
  })
})
mqtt_client.on('message', function (topic, message) {
  // message is Buffer
  console.log(message.toString())
  mqtt_client.end()
})

Instead of console.log I want to pass the output via MQTT. I read that constant 'response' is not global and therefore unknown to the MQTT code below. I have no idea how to fix that

[Hacksore]

Widely untested but you could try something we refer to as "callback hell" 😬.

client.on("ready", async () => {
  const vehicle = client.getVehicle(bluelink_config.vin);
  try {
    const response = await vehicle.status();
    mqtt_client.on("connect", function () {
      mqtt_client.subscribe("kia/status", function (err) {
        if (!err) {
          mqtt_client.publish("kia/status", response);
        }
      });
    });
    
    mqtt_client.on("message", function (topic, message) {
      // message is Buffer
      console.log(message.toString());
      mqtt_client.end();
    });
  } catch (err) {
    // log the error from the command invocation
  }
});

client.on("error", async (err) => {
  // something went wrong with login
});

Hopefully someone has a better idea than this though.

[rediculum]

Thanks Sean. I also tried this approach before. At least it does not throw an error, but nothing is sent to the MQTT. I added the following lines to your code block at the beginning and the end:

console.log('starting query for', bluelink_config.vin);

client.on("ready", async () => {
  const vehicle = client.getVehicle(bluelink_config.vin);
  try {
    const response = await vehicle.status();
    console.log(response);
    mqtt_client.on("connect", function () {
...
...
});

console.log('finished');

The output looks like this:

# node index.js
starting query for KNACC81GXXXXXXX
finished
{ airCtrlOn: false,
  engine: false,
  doorLock: false,
...
...

[cr0ste]

I think what is missing in your code is that you do the connection to MQTT. You just register an event handler on the connect, but I guess connect is never done?

I'm now already moving away from MQTT again and plan to create REST APIs instead.
But here is what I've done so far. I'm doing initialization and login only once (as long as successful) and publish status via MQTT in a loop.

async function ConnectToMqtt() {
    try {
        mqttClient = await MQTT.connectAsync(
            "mqtt://" + mqttConfig.MQTTIP + ":" + mqttConfig.MQTTPORT,
            { username: mqttConfig.MQTTUSER, password: mqttConfig.MQTTPW },
            false);
    } catch (e) {
        console.error("Error in ConnectToMqtt: " + e);
        throw e;
    }
}

async function PushToMqttServer() {
    try {
        const mqttOptions = { retain: true, qos: 1 };

        // Publish just specific status values
        const statusDeviceTopic = "bluelinky/" + niroEVConfig.vin + "/status";
        const statusPayload = JSON.stringify({
            Timestamp: status.time,
            Climatisation_State: status.airCtrlOn,            
            Battery_SoC: status.evStatus.batteryStatus,
            ...        
        });
        await mqttClient.publish(statusDeviceTopic, statusPayload, mqttOptions);
        
        // Alternatively publish all status values
        const fullStatusDeviceTopic = "bluelinky/" + niroEVConfig.vin + "/fullstatus";
        const fullStatusPayload = JSON.stringify(status);
        await mqttClient.publish(fullStatusDeviceTopic, fullStatusPayload, mqttOptions);
    } catch (e) {
        console.error("Error in PushToMqttServer: " + e);
        throw e;
    } finally {
        if (mqttClient) {
            await mqttClient.end();
        }
    }
}

async function Run() {
    await GetInitializedBlueLinky();

    client.on('error', async (err) => {
        console.error("Unhandled error: " + err);
    });

    await Login();

    await GetVehicle(niroEVConfig.vin);
    while (true) {
        try {
            await RefreshStatus();
            await ConnectToMqtt();
            await PushToMqtt();
            await Sleep(delayAfterSuccess);
        } catch (e) {
            console.error("Error during get and push status data loop: " + e);
            await Sleep(delayAfterFailure);
            Run();
        }
    }
}